After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 560032 - PATCH: cheese does not work for cams which support only one resolution
PATCH: cheese does not work for cams which support only one resolution
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
2.24.x
Other Linux
: Normal normal
: 2.24
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-11-09 16:09 UTC by Hans de Goede
Modified: 2008-11-09 18:39 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
PATCH: cheese does not work for cams which support only one resolution (673 bytes, patch)
2008-11-09 16:10 UTC, Hans de Goede 		committed Details | Review

Description Hans de Goede 2008-11-09 16:09:48 UTC 
Hi,

Today I received this bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=470698

The problem here is that for cams which support only one resolution (and do not support the v4l2 ENUM_FRAMEIVAL ioctl). gstreamer will return caps with a range for width and height with range_min == range_max, this currently results in an empty resolution list (and generally not working) in cheese.

The attached patch fixes this, I'll also file a bug against gstreamer as I believe one could call this a gstreamer bug.
Comment 1 Hans de Goede 2008-11-09 16:10:19 UTC 
Created attachment 122268 [details] [review]
PATCH: cheese does not work for cams which support only one resolution
Comment 2 Hans de Goede 2008-11-09 16:14:03 UTC 
gstreamer bug: Bug 560033.
Comment 3 daniel g. siegel 2008-11-09 18:28:43 UTC 
seems ok to me!

hans, do you have a gnome svn account? if not, you should apply for one.

if you dont have one, i will apply the patch
Comment 4 Hans de Goede 2008-11-09 18:32:33 UTC 
(In reply to comment #3)
> seems ok to me!
> 
> hans, do you have a gnome svn account?

No.

> if not, you should apply for one.

Hmm, I already have way too many accounts, so I'll pass for now. If my patch rate goes beyond the occasional bug fix I will get an account.
Comment 5 daniel g. siegel 2008-11-09 18:39:24 UTC 
hehe

i added your patch to gnome-2-24 branch and trunk, thanks a lot!