After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 559885 - Strings contain HTML formatting in gnome-sudoku
Strings contain HTML formatting in gnome-sudoku
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: gnome-sudoku
2.25.x
Other Linux
: High normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on: 97061
Blocks:
 
 
Reported: 2008-11-08 14:32 UTC by Andreas Røsdal
Modified: 2010-04-09 20:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove markup in translatable strings (10.75 KB, patch)
2009-06-02 14:05 UTC, Claude Paroz
committed Details | Review

Description Andreas Røsdal 2008-11-08 14:32:38 UTC
Many strings in the glade user interface dialogs in gnome-sudoku
contain HTML markup in the translatable strings, which is something
that should be avoided. This is what translators see in their .po files:

#: ../gnome-sudoku/glade/puzzle_generator.glade.h:2
msgid "<i>Easy:</i>"
msgstr "<i>Lett:</i>"

This should possibly be changed to "Easy", without formatting in the 
translatable text, and some other means found for format the labels.
Having the same translatable text for "Easy" in all the games will also mean
less work for translators.

This can be fixed in:  gnome-sudoku/glade/puzzle_generator.glade


 - Andreas
Comment 1 Robert Ancell 2008-11-09 00:07:58 UTC
I would be interested in how this can be done because glChess and GCalctool have the same problem. I haven't seen any solution as Glade doesn't seem to provide a way of separating the formatting from the content.

You could set all the strings from the source code but it gets a bit tedious and reduces the advantage having a GUI editor.
Comment 2 Gabor Kelemen 2009-02-12 14:48:34 UTC
For the record: first, you have to convert the application to use GtkBuilder:

http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder

Then, you can get rid of the markup:

http://live.gnome.org/GnomeGoals/RemoveMarkupInMessages
Comment 3 Claude Paroz 2009-06-02 14:05:46 UTC
Created attachment 135810 [details] [review]
Remove markup in translatable strings

Here is a patch to fix this bug. I'm note entirely happy with the literal "1.2" scale value, but I don't think it's possible to use a Pango constant in the .ui (at least not with Glade 3.6.3).
Comment 4 Claude Paroz 2009-07-18 13:50:44 UTC
If noone opposes, I'll soon apply the patch as the string freeze is approaching and I consider the changes trivial.
Comment 5 Thomas Andersen 2010-04-09 20:02:28 UTC
Comment on attachment 135810 [details] [review]
Remove markup in translatable strings

Committed to master:
http://git.gnome.org/browse/gnome-games/commit/?id=e92bbfe9e602f3d32f5e80e448cef3a08f2e9edd

Thanks Claude!