GNOME Bugzilla – Bug 559086
Non-intrusive error handling for calendar
Last modified: 2009-07-29 08:01:06 UTC
We did support mailer errors as non intrusive. In similar way we should have for calendar also.
Created attachment 121860 [details] [review] To provide support for non-intrusive error in calendar.
Changing patch status as per srag's offline review
Patch committed in trunk (revision 36727)
Marking bug as fixed.
Committed in trunk (revision 36735) two files (e-util/e-non-intrusive-error-dialog.c, e-util/e-non-intrusive-error-dialog.h) which i missed in my last commit.
This introduced some warnings during the compile time. Please fix them: e-non-intrusive-error-dialog.c: In function ‘eni_show_logger’: e-non-intrusive-error-dialog.c:212: warning: passing argument 4 of ‘g_signal_connect_data’ discards qualifiers from pointer target type e-non-intrusive-error-dialog.c:237: warning: passing argument 4 of ‘g_signal_connect_data’ discards qualifiers from pointer target type calendar-commands.c: In function ‘help_debug’: calendar-commands.c:560: warning: implicit declaration of function ‘calendar_component_show_logger’ calendar-component.c:1850: warning: no previous prototype for ‘calendar_component_peek_activity_handler’ ../../e-util/e-non-intrusive-error-dialog.h:53: warning: ‘eni_query_tooltip_cb’ declared ‘static’ but never defined ../../e-util/e-non-intrusive-error-dialog.h:55: warning: ‘eni_render_pixbuf’ declared ‘static’ but never defined ../../e-util/e-non-intrusive-error-dialog.h:57: warning: ‘eni_render_date’ declared ‘static’ but never defined ../../e-util/e-non-intrusive-error-dialog.h:59: warning: ‘eni_append_logs’ declared ‘static’ but never defined ../../e-util/e-non-intrusive-error-dialog.h:60: warning: ‘eni_error_timeout_changed’ declared ‘static’ but never defined ../../e-util/e-non-intrusive-error-dialog.h:61: warning: ‘eni_error_level_value_changed’ declared ‘static’ but never defined ../../e-util/e-non-intrusive-error-dialog.h:62: warning: ‘eni_config_get_error_level’ declared ‘static’ but never defined e-calendar-view.c: In function ‘e_calendar_utils_show_error_silent’: e-calendar-view.c:2427: warning: implicit declaration of function ‘calendar_component_peek_activity_handler’ e-calendar-view.c:2427: warning: initialization makes pointer from integer without a cast e-calendar-view.c: In function ‘e_calendar_utils_show_info_silent’: e-calendar-view.c:2439: warning: initialization makes pointer from integer without a cast gnome-cal.c: In function ‘backend_died_cb’: gnome-cal.c:3078: warning: passing argument 2 of ‘g_hash_table_insert’ discards qualifiers from pointer target type gnome-cal.c:3079: warning: passing argument 4 of ‘g_signal_connect_data’ discards qualifiers from pointer target type ../e-util/e-non-intrusive-error-dialog.h:53: warning: ‘eni_query_tooltip_cb’ declared ‘static’ but never defined ../e-util/e-non-intrusive-error-dialog.h:55: warning: ‘eni_render_pixbuf’ declared ‘static’ but never defined ../e-util/e-non-intrusive-error-dialog.h:57: warning: ‘eni_render_date’ declared ‘static’ but never defined ../e-util/e-non-intrusive-error-dialog.h:59: warning: ‘eni_append_logs’ declared ‘static’ but never defined ../e-util/e-non-intrusive-error-dialog.h:60: warning: ‘eni_error_timeout_changed’ declared ‘static’ but never defined ../e-util/e-non-intrusive-error-dialog.h:61: warning: ‘eni_error_level_value_changed’ declared ‘static’ but never defined ../e-util/e-non-intrusive-error-dialog.h:62: warning: ‘eni_config_get_error_level’ declared ‘static’ but never defined
Ashish, Akhil: What is so hard to test and compile this first with restrictive settings? Fix your flags/parameters, please. NOW.
I took care of it. Revision 36738.
*** Bug 314914 has been marked as a duplicate of this bug. ***