GNOME Bugzilla – Bug 559031
some cities have Unknown timezone
Last modified: 2009-11-02 17:29:23 UTC
+++ This bug was initially created as a clone of Bug #559018 +++ It seems that not all the cities listed comes with a timezone attached with it. Some cities such as Paris and New York work fine, they have a timezone attached to them, other cities do not have timezones need to be fixed. Some examples of these are: Arviat, Nunavut Yellowknife, NWT Montreal, Quebec Radisson, Quebec Oral, Kazakhstan Shymkent, Kazakhstan Qyzylorda, Kazakhstan Burwash Landing, Yukon
*** Bug 568453 has been marked as a duplicate of this bug. ***
i can confirm that bug on Ubuntu Jaunty alpha with final GNOME 2.26 : Montreal (canada) can't be set
Created attachment 146515 [details] [review] Look up for obsolete tzdata identifiers for locations. Patch to look up the `obsoletes' tags in Locations.xml in order to find the appropriate time zone for every location. Hopefully fixes this bug. An equivalent patch is also proposed as a fix in Ubuntu bug #291853. See https://bugs.launchpad.net/ubuntu/+source/libgweather/+bug/291853
doh. actually, the right fix is that we just shouldn't be using the obsolete timezones. data/check-timezones.sh (which gets run as part of make check) ought to check this.
Created attachment 146534 [details] [review] Add a check for obsolete tzdata identifiers used in Locations.xml.in The script data/check-timezones.sh compares the tzdata identifiers in Locations.xml.in with the system's tzdata, but (at least in case of Ubuntu) the database contains even the timezones that libgweather considers obsolete. The reasons for the differences are well explained in data/README.timezones. The included patch adds a check for obsolete tzdata identifier that are actually used for some locations. It should then be quite easy to fix the Locations.xml.in file to use the correct timezones.
Created attachment 146682 [details] [review] Replace obsolete tzdata identifiers in Locations.xml.in This patch replaces the obsolete tzdata identifiers as per the output of the script updated with attached patch #146534. Should fix bug #559031.
Excellent. Thanks for the debugging and the patch