And let's move that function over to ../gtk/somewhere

Do you still need an url_show function in goffice when there is gtk_show_uri?

The unix part of go_url_show just calls gtk_show_uri (or g_app_info_launch_uri if gtk_show_uri is not available).

I think for the windows part you do not need it either, as gtk_show_uri should work on windows too, I guess. Can someone verify that gtk_show_uri works on windows?

So maybe you can just drop go_url_show from goffice completely.

> Do you still need an url_show function in goffice when there is gtk_show_uri?

In the long run, no.  But we do not like to depend on the very latest from
the gtk+ people.

> So maybe you can just drop go_url_show from goffice completely.

We also like to maintain the interface, just in case someone else uses it.
Having a ten-line wrapper doesn't really hurt us.

Would go_url_show_for_screen a good name for the new function? We might also want a timestamp, or not?

Created attachment 129923 [details] [review]
proposed patch

I'd not move go_url_show to gtk since it is needed even for without-gtk builds.

Looks good, apart from the "Since:" line.

Yes, 0.8 would be better ;-)

Patch commited without the faulty "Since" line.