GNOME Bugzilla – Bug 558674
registry: don't copy strings when reading the cache
Last modified: 2018-11-03 12:13:02 UTC
There are some enhancement idea about the gstreamer registry described in Bug #359653#c35 and Bug #359653#c36. This is an attempt to do it.
Created attachment 121735 [details] [review] latest patch, needs update in 3 hunks
Looks good but you're breaking ABI in GstPluginFeature and GstRegistry by adding stuff but not making the padding smaller ;)
Created attachment 121850 [details] [review] avoid copying strings now applies cleanly and has abi stability fixed. needs more commenting and testing
Created attachment 121852 [details] [review] avoid copying strings one less instance var. did several meassurements, but it fluctuates too much. speed is in same range as before
We should use the GstObject flags for the plugins and features instead of adding new fields and methods.
Created attachment 121863 [details] [review] avoid copying strings Last patch missed some things. Need to readd mmap usage and make sure it keep working. Wim, I was wondering if GST_OBJECT_FLAG_CONST is to generic. Should we name it GST_OBJECT_FLAG_CONST_STRINGS an define that (all?) gchar * fields in that object are not to be free'ed on destruction.
Tim, didn't you have a more generic proposal for making the registry based on GVariant (and only loading data on-demand) ?
Yes, but punting it to the next cycle. I'd like to keep this open for now.
Comment on attachment 121863 [details] [review] avoid copying strings Rejecting because the plan is to just go with GVariant now
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer/issues/9.