After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 558323 - glitches when popping up combos in treeviews
glitches when popping up combos in treeviews
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkComboBox
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 559109 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-29 01:03 UTC by Tristan Van Berkom
Modified: 2009-08-27 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
This source file demonstrates the problem (13.26 KB, patch)
2008-10-31 05:36 UTC, Tristan Van Berkom
none Details | Review

Description Tristan Van Berkom 2008-10-29 01:03:50 UTC
I encountered a problem when using a cellrenderercombo
and setting the model in the underlying store (i.e. the 
renderer's "model" property set retrieved as an attribute).

What happens:
  - The combo shows up empty and in prelight state and sits there
  - upon clicking, 2 things can happen, 
     a.) the proper list drops down, and prelight/selection just
         doesnt work
     b.) the proper list drops down, probably over 100 times
         per second
  - in either scenarios its difficult to get the combo to ever
    go away (involves lots of clicking).

I'm filing this as a combobox bug since tracing the code showed
me that the cellrenderer and celleditable start_editing seem to
pass fine, and they dont get called repeatedly while the combo
keeps dropping down its menu...

I'm sure this is some kind of regression, since compiling my app
back into /usr against installed gtk+ (I have 2.12.9 in my
gtk+-2.0.pc) and it seems to work fine there.

Note I havent updated my trunk in a little while, I will some
time next week and I'll let you know if the problem went away.
Comment 1 Tristan Van Berkom 2008-10-29 01:50:12 UTC
Actually more info, in 2.12, they dont actually work properly
either, but better.

in 2.12 they are activatable by key-press (enter on a focused cell)
but you cant get the combo to drop down by clicking on it (same
scenario, with model set in the underlying store...)
Comment 2 Tristan Van Berkom 2008-10-29 02:28:18 UTC
I built trunk just now, problem still there.
Comment 3 Matthias Clasen 2008-10-31 03:08:58 UTC
A testcase would be awesome for this.
Comment 4 Tristan Van Berkom 2008-10-31 05:36:05 UTC
Created attachment 121713 [details] [review]
This source file demonstrates the problem

wasnt too hard to rip out the naked dialog :)

have fun :)
Comment 5 Matthias Clasen 2008-10-31 18:22:30 UTC
This fixes it:

2008-10-31  Matthias Clasen  <mclasen@redhat.com>

        Bug 558323 – glitches when popping up combos in treeviews

        * gtk/gtkcellrenderercombo.c (gtk_cell_renderer_combo_set_property):
        Don't set the model property on the combo box, since that leads
        to loops.

Note to self: never pass cellrenderer properties thru to cell editors after start-editing, since the renderer _will_ be used to render other cells while one is being edited.
Comment 6 Matthias Clasen 2008-11-04 06:36:16 UTC
*** Bug 559109 has been marked as a duplicate of this bug. ***
Comment 7 Sebastien Bacher 2008-12-16 11:56:16 UTC
should the bug be closed?
Comment 8 Kristian Rietveld 2009-08-27 14:24:59 UTC
Think so ;)  Closing.