After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557808 - don't use libgnome
don't use libgnome
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on: 557806
Blocks:
 
 
Reported: 2008-10-24 20:25 UTC by William Jon McCann
Modified: 2008-11-03 18:53 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description William Jon McCann 2008-10-24 20:25:08 UTC
Seems like we only use libgnome in the daemon for gnome_program_init().  If we drop libgnome we would have to link to dozens fewer libs.
Comment 1 Jens Granseuer 2008-10-25 11:11:01 UTC
I think the only reason we currently use (and need) libgnome is the sound plugin. When we drop that it should be easy to drop the dependency as well.
Comment 2 Steve Frécinaux 2008-10-29 09:31:40 UTC
Isn't it possible to dlopen it from the sound plugin ?
Comment 3 Rodrigo Moya 2008-10-29 13:30:21 UTC
The sound plugin should probably just be changed to use libcanberra for the sample playing (not sure why it needs to do that really). Also, if we are moving to PulseAudio, there is no need to start ESD, which is what gnome_sound is used for.
Comment 4 Jens Granseuer 2008-10-29 17:35:58 UTC
(In reply to comment #2)
> Isn't it possible to dlopen it from the sound plugin ?

Even if it was (which I don't think it is in this case, haven't really investigated, though), what's the point?

a) is dlopen any faster than linking directly? That'd be rather broken.
b) we don't need the sound plugin anymore if we drop esd, so why bother?

(In reply to comment #3)
> The sound plugin should probably just be changed to use libcanberra for the
> sample playing (not sure why it needs to do that really). Also, if we are
> moving to PulseAudio, there is no need to start ESD, which is what gnome_sound
> is used for.

The sound plugin doesn't play samples. We don't need it.
Comment 5 Jens Granseuer 2008-10-29 19:41:12 UTC
2008-10-29  Jens Granseuer  <...>

        Get rid of libgnome (bug #557808).

        * configure.ac: bump required gtk+ version to 2.13.1
        * gnome-settings-daemon/main.c: (main): don't use g_program_init
        * plugins/a11y-keyboard/Makefile.am:
        * plugins/a11y-keyboard/gsd-a11y-keyboard-manager.c:
        (ax_response_callback), (ax_stickykeys_response),
        (ax_slowkeys_response), (on_slow_keys_action),
        (on_sticky_keys_action): replace gnome_help_display_desktop with
        gtk_show_uri
Comment 6 Behdad Esfahbod 2008-11-03 16:52:10 UTC
This btw has done little to improve our startup time, as libgnome-desktop pull them all in again.  So, while the ldd of gnome-settings-daemon has gone down to below 50, the plugins are all still at 80.  Needs libgnome-desktop to be broken into deprecated and living parts.
Comment 7 Behdad Esfahbod 2008-11-03 18:53:57 UTC
My bad.  gnome-desktop in trunk doesn't drag them in.