After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 557378 - input-selector element makes subtitles pop up at unexpected times
input-selector element makes subtitles pop up at unexpected times
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.8
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-22 10:33 UTC by Andreas Frisch
Modified: 2009-03-17 21:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
possible patch (7.15 KB, patch)
2008-10-30 11:55 UTC, Wim Taymans
none Details | Review

Description Andreas Frisch 2008-10-22 10:33:18 UTC
Please describe the problem:
when using an input-selector element to be able to switch between different subtitle tracks out of a matroska container, the timing of the subtitle callbacks gets messed up - callbacks generally happen too early.

Steps to reproduce:
1. gst-launch filesrc location=[testvideo.mkv] ! matroskademux name=d d.video_00 ! queue ! [videosink]  d.audio_00 ! queue ! [audiosink]  d.subtitle_00 ! ssaparse ! fakesink dump=true async=false sync=True
2. gst-launch filesrc location=[testvideo.mkv] ! matroskademux name=d d.video_00 ! queue ! [videosink]  d.audio_00 ! queue ! [audiosink]  d.subtitle_00 ! input-selector ! ssaparse ! fakesink dump=true async=false sync=True


Actual results:
first command shows the subtitles buffers at expected times
second command results in subtitle buffers being handed off too quickly

Expected results:
i would expect the input-selector element not to affect the timing of subtitles

Does this happen every time?
yes. it also happens in a C++ application where signal-handoffs of the fakesink is connected to a subtitle rendering callback function

Other information:
test container file where this behaviour can be observed is available at http://rapidshare.com/files/156262942/testmovie.zip.html
Comment 1 Andreas Frisch 2008-10-22 11:29:43 UTC
the timing issue doesn't occur with SRT subtitles coming from a seperate file and going through an input-selector element aswell.
Comment 2 Wim Taymans 2008-10-22 11:55:38 UTC
input-selector has trouble with the accumulated segments.
Comment 3 Andreas Frisch 2008-10-29 19:30:36 UTC
any news already?
btw: isn't this bug technically confirmable?
Comment 4 Wim Taymans 2008-10-30 11:55:13 UTC
Created attachment 121637 [details] [review]
possible patch

This patch fixes the reported bug but might break the original operation of the selector when switching streams.
Comment 5 Andreas Frisch 2008-10-31 12:28:46 UTC
Tested and works fine for me in a rather complex pipeline inside my application
typically something like

filesrc mkv !
! matroskademux audio1 \
! matroskademux audio2 ~ ! input-selector ! audiosink
! matroskademux audio3 /


filesrc external srt file ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ \
! matroskademux SSA subtitle  \ 
! matroskademux SSA subtitle  ~ ! input-selector ! ssaparse ~ ! input-selector
! matroskademux SSA subtitle  /
! matroskademux utf8 subtitle \
! matroskademux utf8 subtitle ~ ! input-selector ! subparse /
! matroskademux utf8 subtitle /

Comment 6 Andreas Frisch 2009-03-17 21:26:11 UTC
this issue is - from our point of view - obsolete. playbin2 doesn't seem to have this problem.