After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 556776 - clock weather display doesn't recover quickly from partial network connectivity
clock weather display doesn't recover quickly from partial network connectivity
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: clock
2.24.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-17 19:28 UTC by Dan Winship
Modified: 2008-10-20 15:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (4.18 KB, patch)
2008-10-17 19:36 UTC, Dan Winship 		committed Details | Review

Description Dan Winship 2008-10-17 19:28:01 UTC 
If you connect to a wifi hotspot that requires authentication (or just acceptance of terms-of-service), NM will consider you to be connected to the network, but attempting to refresh the weather data in the clock will fail because, really, you aren't.

downstream: https://bugzilla.redhat.com/show_bug.cgi?id=448103
Comment 1 Dan Winship 2008-10-17 19:36:20 UTC 
Created attachment 120802 [details] [review]
patch

I've added a new method to WeatherInfo in libgweather to distinguish "couldn't load weather info because that code is invalid" from "couldn't load weather info because of a network problem", and this patch makes the clock applet check for the latter condition, and retry sooner in the case of a network failure.
Comment 2 Vincent Untz 2008-10-20 15:50:23 UTC 
Looks good. Just remove the g_warning(). They look more like debug stuff than real warnings :-)
Comment 3 Dan Winship 2008-10-20 15:57:21 UTC 
oops, those weren't supposed to have been in the patch.

committed