GNOME Bugzilla – Bug 555425
"Desktop" name is now "x-nautilus-desktop"
Last modified: 2013-01-09 23:29:18 UTC
Somewhere along the line (GNOME 2.22 to GNOME 2.24?) the accessible name for the desktop changed from the human-consumable string, "Desktop", to the programmatic string "x-nautilus-desktop". Assistive technologies present the accessible name to users, so the change has caused programmatic strings to be exposed to end users. This represents a problem with non-English locales because "x-nautilus-desktop" is not translated.
Created attachment 154483 [details] [review] patch for desktop URI eel/eel-vfs-extensions.h: changed EEL_DESKTOP_URI nautilus-convert-metadata.c: libnautilus-private/nautilus-file-operations.c: added EEL_DESKTOP_URI instead of x-nautilus-desktop
The internal uri for the desktop is x-nautilus-desktop://, this is stored in various places etc and should not be changed. What should be fixed is the accessible name for it, not the uri.
Alexander, greping thro the code I found only two references of internal uri that I changed to use EEL_DESKTOP_URI. Is there any other way of doing this?
Will, Could you please help us provide a accessible name for this
(In reply to comment #4) > Will, Could you please help us provide a accessible name for this I think "Desktop" would be a reasonable name. Thanks so much for looking at this! Will
How can I test this attached patch? What source code need I downloading before I applying the attached patch The desktop accessible name is good I think. Arki, your patch marking this name for translation if committed in future? For example in hungarian language translation desktop means asztal. Attila
Attila, You to apply to nautilus source git clone git://git.gnome.org/nautilus Regarding the translation, we should wait until a proper patch commited to source code.
Arki, thank you, I looking the patch. Attila
Arki, your patch working me correct, Orca spokening Desktop accessible name correct when I switch navigation to desktop with Ctrl+Alt+d. I don't no how can possible marking this name for translation, but I hope this is not difficult. Thank you the patch. Attila
Created attachment 155034 [details] [review] This is a test patch only. Arki, I little modify your patch, but my method is not full working. In eel/eel-vfs-extensions.h I add the N_( tag with Desktop URL section (marked translation the "desktop:" string). I put the POTFILES.in file the eel/eel-vfs-extensions.h file. The "desktop:" string is present with nautilus hu.po translation file when I ran intltool-update hu command, but if I translate the string and remove the fuzzy mark, recompiling Nautilus, Orca spokening Desktop string, not the translated string. I forgot do some need modification? Attila
Created attachment 155044 [details] [review] a different approach As alex already said, changing the URI is not the right approach. The URI should not be modified. The accessible name for the desktop window should be set instead. From reading the documentation (http://live.gnome.org/GAP/AtkGuide/GtkAtk), it looks as if we need something like this patch. I have no idea whether it works, though... I imagine if this is the right way to do it, then there are quite a few other locations within Nautilus which could use similar patches.
Thank you Walton, I think you got it right. Will, What do you reckon? One other location we need need something like this is here https://bugzilla.gnome.org/show_bug.cgi?id=610789
Walton, I tried your patch and it didn't compile. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ CC nautilus-bookmarks-window.o CC nautilus-connect-server-dialog.o CC nautilus-connect-server-dialog-nonmain.o CC nautilus-desktop-window.o cc1: warnings being treated as errors nautilus-desktop-window.c: In function ‘nautilus_desktop_window_init’: nautilus-desktop-window.c:77: error: passing argument 1 of ‘gtk_widget_get_accessible’ from incompatible pointer type /usr/include/gtk-2.0/gtk/gtkwidget.h:1043: note: expected ‘struct GtkWidget *’ but argument is of type ‘struct NautilusDesktopWindow *’ make[4]: *** [nautilus-desktop-window.o] Error 1 make[4]: Leaving directory `/home/iise/src/nautilus/src' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/iise/src/nautilus/src' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/iise/src/nautilus/src' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/iise/src/nautilus' make: *** [all] Error 2 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Created attachment 155764 [details] [review] take two Yeah, missed a cast. Sorry about that.
Created attachment 155835 [details] Screenshot after the patch The patch doesn't seem to work as expected.
Arki, what show the screenshot? I can not see the screenshot, because I am full blind. What the problem? My machine after I applying new patch, Nautilus compiling correct, and if I reinstall new version, Orca says Desktop when I navigating the desktop after logout and login. Or the problem is another place (another x-nautilus part problems)? Attila
After building nautilus with Walton's second patch, the accessible name of desktop is still 'x-nautilus-desktop' Attila, can you test the second patch as well.
I tested again, but working correct my machine. I do following: 1. I removed entire nautilus source code, and fetched again the source from git. Prewious patch applying I do only git reset --hard before apply the patch, I want clean compilation. 2. I apply following patch file, the name is: set-desktop-accessible-name.diff 3. I run following commands in Nautilus source code directory: ./autogen.sh make uninstall >/dev/NULL (sure uninstall prewious entire nautilus) make >/dev/NULL make install >/dev/NULL After all process is completed, I restart my system. I testing change with english system language. I hear Desktop string, not x-nautilus-desktop string. And, very interesting but I am happy, in hungarian language I hear "Asztal" string again. I tested two time the patch. I am using Ubuntu Lucid both you, and all this day morning system updates are installed. Hope this helps, Attila
Thank you Attila, You are correct the desktop is read as 'Desktop' frame. I'll see if I can patch other places as well
Walton, when you switch panel with 'Control + Alt + Tab' the desktop window is annonced as 'x-nautilus-desktop'. Wonder why this happens?
Oh, Arki I understand now your problem. I confirmed, tryed. Attila
Comment on attachment 155764 [details] [review] take two This looks good to commit after branching (marks a new string for translations), but it's not enough to fix the bug completely.
Is this patch good enough to be patched?
Hy Arky, Earlier I used my test system with longer time and not see drastical problems with Nautilus 2.29.x or 2.30, now I not remember what the correct version number when I use this patch. When I press for example the Ctrl+Alt+d key combination, Orca right spokening "asztal" string if the hungarian locale is choosed. But I see a problem if I cicle switch panels and desktop, Orca I think spokening x-nautilus-desktop string. If this is help and you want, thursday I welcome look the actual patch, if you tell me how can possible download in git only the 2.30 branch Nautilus source code, now I not remember the correct sintax. Attila
Comment on attachment 155764 [details] [review] take two (In reply to comment #22) > (From update of attachment 155764 [details] [review]) > This looks good to commit after branching Nautilus has branched for 2.30. Please commit.
Attila, the panel switcher issue needs a different patch. Looking into it and hopefully fix it soon. You can get the source using the steps mentioned in the Git for Gnome developer guide http://live.gnome.org/Git
Changing component as a part of ongoing bug reorganisation work.
Comment on attachment 155764 [details] [review] take two Pushed this to master.
Cosimo, could this bug be closed then?
No, see comment #24.
I don't know if this is the same bug or different, but as mentioned in comment 20, the name of the desktop window in the Ctrl-Alt-Tab switcher is also "x-nautilus-desktop", which is because that's the title of the desktop window. Is there any reason that can't be changed? (This may also be the cause of comment 24, and may render the previously-committed patch irrelevant if fixed.) I poked around a little but I don't know the nautilus code, and couldn't figure out where the NautilusDesktopWindow's title was getting set...
(In reply to comment #31) > I don't know if this is the same bug or different, but as mentioned in comment > 20, the name of the desktop window in the Ctrl-Alt-Tab switcher is also > "x-nautilus-desktop", which is because that's the title of the desktop window. Yeah, it's the same bug. I applied a proper fix to git master, this works as expected now. Closing as FIXED.
i suspect you can revert attachment 155764 [details] [review] now as well
*** Bug 607730 has been marked as a duplicate of this bug. ***