Created attachment 119723 [details] [review]
patch for warnings

       g_set_error (&priv->error,
 		   GTK_PRINT_ERROR,
 		   GTK_PRINT_ERROR_GENERAL,
+		   "%s",
 		   cairo_status_to_string (cairo_surface_status (surface)));

You can use g_set_error_literal in this case.

Yes, with that one change to use g_set_error_literal, it looks fine.

Created attachment 119845 [details] [review]
updated patch

Does this look ok then?

yes, looks fine

This was already done on trunk it seems. Close it or apply it to 2.14.x too?

(In reply to comment #4)
> Created an attachment (id=119845) [edit]
> updated patch
> 
> Does this look ok then?

Yes, please apply and close this bug.

(In reply to comment #7)
> (In reply to comment #4)
> > Created an attachment (id=119845) [edit]
> > updated patch
> > 
> > Does this look ok then?
> 
> Yes, please apply and close this bug.

The patch was already applied, the only question is whether it should also go into 2.14 or not. I personally don't think it's worth it, though.

(In reply to comment #6)
> This was already done on trunk it seems. Close it or apply it to 2.14.x too?

This should go into 2.14 as well, because printf variants with a custom unchecked format string are potential security holes (e.g. as "%s" causes references to random/invalid memory addresses).

Commited. Thanks.