After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554348 - GnomeGoals: using LINGUAS file
GnomeGoals: using LINGUAS file
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: Compilation
git master
Other All
: Normal enhancement
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-09-29 19:12 UTC by fpacanowski
Modified: 2008-10-08 01:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
This patch adds po/LINGUAS and modifies configure.in (1.33 KB, patch)
2008-09-29 20:29 UTC, fpacanowski 		needs-work Details | Review
Revised patch (21.78 KB, patch)
2008-10-03 00:15 UTC, Morten Welinder 		needs-work Details | Review
Updated patch (22.33 KB, patch)
2008-10-03 22:57 UTC, Morten Welinder 		committed Details | Review

Description fpacanowski 2008-09-29 19:12:56 UTC 
I suggest to create po/LINGUAS file with list of languages instead of list in configure.in, according to http://live.gnome.org/GnomeGoals/PoLinguas

Other information:
Comment 1 fpacanowski 2008-09-29 20:29:11 UTC 
Created attachment 119614 [details] [review]
This patch adds po/LINGUAS and modifies configure.in

This is the first patch I have ever written, please mail me if it is not correct.
Comment 2 Morten Welinder 2008-09-30 17:29:05 UTC 
Can we have comments in the LINGUAS file?  We need to make sure that
new languages only get added after translations for both po/ and
po-functions/ are available.
Comment 3 Jean Bréfort 2008-09-30 18:35:53 UTC 
Every line starting with a '#' is a comment. po/Makefile has:

PO_LINGUAS=$(shell if test -r $(srcdir)/LINGUAS; then grep -v "^\#" $(srcdir)/LINGUAS; fi)
Comment 4 Morten Welinder 2008-09-30 23:21:34 UTC 
This does seem to work.  (And it should be done against svn trunk, not 1.8.x)

Nothing gets made in po/ and nothing gets made in po-functions/
Comment 5 fpacanowski 2008-10-01 10:38:18 UTC 
>Nothing gets made in po/ and nothing gets made in po-functions/
Did you patch it with patch -p1 < linguas.patch ?
Comment 6 Morten Welinder 2008-10-01 12:14:49 UTC 
yes
Comment 7 Morten Welinder 2008-10-03 00:15:31 UTC 
Created attachment 119833 [details] [review]
Revised patch

Something like this is needed.

Jody: what were we patching in Makefile.in.in.own?  I simply replaced it
with a fresh copy.
Comment 8 Morten Welinder 2008-10-03 00:17:59 UTC 
Still doesn't work in po-functions, though.
Comment 9 Morten Welinder 2008-10-03 22:57:10 UTC 
Created attachment 119892 [details] [review]
Updated patch

This version seems to work in po-functions too.

Jody: the question regarding patches remains.