After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552807 - make placeholder implement set-scroll-adjustments
make placeholder implement set-scroll-adjustments
Status: RESOLVED FIXED
Product: glade
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-18 17:26 UTC by Christian Persch
Modified: 2010-03-30 18:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Make GladePlaceholder able to be placed in a GtkScrolledWindow. (2.07 KB, patch)
2008-09-18 17:27 UTC, Christian Persch
none Details | Review

Description Christian Persch 2008-09-18 17:26:12 UTC
When you add a GtkScrolledWindow to your glade interface, you get a warning on console because GladePlaceholder doesn't implement the set-scroll-adjustments signal.
Comment 1 Christian Persch 2008-09-18 17:27:28 UTC
Created attachment 118965 [details] [review]
[PATCH] Make GladePlaceholder able to be placed in a GtkScrolledWindow.

 gladeui/glade-marshallers.list |    1 +
 gladeui/glade-placeholder.c    |   11 +++++++++++
 gladeui/glade-placeholder.h    |    4 ++++
 3 files changed, 16 insertions(+), 0 deletions(-)
Comment 2 Christian Persch 2008-11-04 22:24:56 UTC
Ping? Ok to commit this patch?
Comment 3 Tristan Van Berkom 2008-11-04 22:48:39 UTC
I dont feel the warning warrants adding scrolling capabilities to
placeholders.

Maybe if we want to avoid the warning we could just make the 
adaptor->add()/adaptor->replace_child() implementations
for scrolled window use scrolled_window_add_with_viewport() in the
case of non-scrollable children instead ?
Comment 4 Tristan Van Berkom 2008-11-05 06:29:29 UTC
Note, that would mask the problem in glade and leave the problem
in the resulting application.

The real plan I've had in mind for this was to put it off
until we get a proper logging api in glade, in which case
we could save logs from gtk+ and put it in a widget complaint 
domain.

The option of actually handling an added viewport in the
project is also complex, the core wont allow for
recording commands in recursive ways (which means no
adding viewports in backend ->add() implementations).

I think we should think twice for now about removing the
error message.
Comment 5 Christian Persch 2010-03-30 18:47:55 UTC
This is fixed on master.