GNOME Bugzilla – Bug 550816
[PATCH] Don't set r/o permissions when copying from r/o locations
Last modified: 2009-05-15 16:22:37 UTC
Please describe the problem: Hi!, this is a regression from bug 167102 , the feature was lost in the migration to gio, the gio patch for this is in bug 550795 , I'm attaching here the patch for nautilus. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 117995 [details] [review] Set G_FILE_COPY_TARGET_DEFAULT_PERMS when copying from r/o locations Set G_FILE_COPY_TARGET_DEFAULT_PERMS flag to files in a copy job when they're in a readonly filesystem ("filesystem::readonly" attribute), also set the flag when doing g_file_copy_attributes() on foldres being created as part of that copy job..
Thanks, good job! Feel free to commit it as soon as you have approval from the gvfs people - and raise the required gvfs version in configure.in.
It's now commited, marking as fixed, thank you!
Wait a sec... you need to branch before doing that!
Nelson, I reverted your commit as we can't depend on GLib 2.19.0 before branching. Setting patch status as "commit_after_freeze" so that we can commit it after branching.
(In reply to comment #5) > Nelson, I reverted your commit as we can't depend on GLib 2.19.0 before > branching. > Setting patch status as "commit_after_freeze" so that we can commit it after > branching. > Ok, thanks Cosimo, and sorry for the incovenience, I thought it could be commited to trunk.
*** Bug 523129 has been marked as a duplicate of this bug. ***
Actually, I'm not sure we can apply this as is when we branch fro gnome 2.26 either. The release cycle of glib is generally longer than for Gnome, so we might not be using the new glib in Gnome 2.26. I'd recommend adding a configure check for G_FILE_COPY_TARGET_DEFAULT_PERMS and using it if availible instead.
Ok, I prefer to wait to when nautilus can use glib 2.19.0 than cluttering the code with #ifdefs.
(In reply to comment #8) > Actually, I'm not sure we can apply this as is when we branch fro gnome 2.26 > either. The release cycle of glib is generally longer than for Gnome, so we > might not be using the new glib in Gnome 2.26. > > I'd recommend adding a configure check for G_FILE_COPY_TARGET_DEFAULT_PERMS and > using it if availible instead. It seems that GLib 2.20 will be released in time for GNOME 2.26, so I guess we could commit this to trunk?
Yes, we now depend on 2.19.0, so this can go in again.
(In reply to comment #11) > Yes, we now depend on 2.19.0, so this can go in again. I have committed it, so this is now fixed, thank you :)
*** Bug 570593 has been marked as a duplicate of this bug. ***
I'm under Ubuntu 9.04 and this bug still annoys me, since 8.04 to be exact. I'm new here and haven't understood how to apply this patch to solve the problem. Can you please write here a step-by-step to aply the patch in Ubuntu 9.04 (nautilus 2.26.2)?
Hi Cristiano, I'm also on ubuntu 9.04 and this works fine for me, so it's probably a problem with your setup.
Thanks Nelson. I was using a modified Ubuntu 9.04 I get on the web. Now I've just checked it out on the normal Ubuntu and it works fine. Sorry for the inconvenience.