GNOME Bugzilla – Bug 55047
Select a tools from the menu bar does not work
Last modified: 2004-12-22 21:47:04 UTC
When selecting a tool from the menu bar, I get this warning. ** WARNING **: called dia_menu_signal_proxy with NULL signal_handler !
This is a temporary fix to #52836, which caused a crash. Why there is a NULL handler in the first place, I don't know (you're surely more knowledgable about menus than I am).
Orignal reporter did use 0.88.1. Reproducible in CVS.
menus_set_tools_callback is not called in GNOME build. It is only called in the case of pure Gtk menu build. Whether it is popup or menu bar does not matter since both behave the same (it took care of that).
Comment above is incorrect: menus_set_tools_callback()get called (this function is new to post 0.88.1). However, here are some thought: -In menus_get_item_from_path(), there is a check that if we don't have a display and we ask for a display menu, we should return NULL. This is a false assumption as we call this function during toolbox window creation before any display window is constructed, this call being performed from menus_set_tools_callback() to set up callbacks for tool selection. This happens only if defined(GNOME) since Gtk build use a different code in menus_get_item_from_path(). This is problem #1. It does not fix it but get furher.
-this problem is a regression from 0.86 since 0.86 works. -I get warning anyway, but in current CVS version, with the fix above, if I use popup menu it works despite verbosity. For menu bar, menus_set_tools_callback was only called for GTK. Fixing that. -dia_menu_signal_proxy is emitting the warning, it was not in 0.86. dia_menu_signal_connect_func() connects a dia_menu_signal_proxy() to the widget even if there is not signal handler defined in the uiinfo. This is not good and produce the warning. The fix is to check the signal and connect only if non NULL.
Created attachment 591 [details] [review] this patch fixes this bug and some other not reported.
patch applied.
works fine.