After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549886 - Property notification should work entirely through window-props
Property notification should work entirely through window-props
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: Metacity maintainers list
Metacity maintainers list
Depends on:
Blocks:
 
 
Reported: 2008-08-30 00:23 UTC by Thomas Thurman
Modified: 2009-02-23 23:27 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Thomas Thurman 2008-08-30 00:23:37 UTC
At present PropertyNotify makes calls into window-props for many but not all properties.  It should call in for everything.

My original question about this:
http://mail.gnome.org/archives/metacity-devel-list/2008-August/msg00000.html

Havoc replied ccing metacity-devel-list, but it seems not to have been archived; I'm reproducing it below:

-----

What "call reload" means is meta_window_reload_property(). If you'll
notice, most of the branches in the if-else just call
meta_window_reload_property(). When *all* the branches just call
meta_window_reload_property(), you can delete the whole if/else and
unconditionally call meta_window_reload_property(). "move to
window-props.h" means "add MetaWindowPropHooks for the property"

The MetaWindowPropHooks are one init func and one reload func, so when
you add them, generally the code on window init that reads the prop is
replaced, and the code on property notify is also replaced.
Comment 1 Thomas Thurman 2009-01-27 05:05:26 UTC
Fix committed.  http://svn.gnome.org/viewvc/metacity?rev=4090&view=rev and preceding.
Comment 2 Ori Avtalion 2009-02-21 20:04:14 UTC
This fix caused a regression as reported in bug 572682.
Comment 3 Ori Avtalion 2009-02-23 23:27:16 UTC
Another possible regression is reported in bug 572921.