After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549621 - swfdec-gnome misuses _LDFLAGS automake variable, fails to build with --as-needed forced on
swfdec-gnome misuses _LDFLAGS automake variable, fails to build with --as-nee...
Status: RESOLVED FIXED
Product: swfdec-gnome
Classification: Deprecated
Component: general
2.22.x
Other All
: Normal normal
: ---
Assigned To: swfdec-gnome-maint
swfdec-gnome-maint
Depends on:
Blocks:
 
 
Reported: 2008-08-27 19:30 UTC by Diego Elio Pettenò
Modified: 2008-08-28 08:53 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22

Attachments
Patch to fix. (1015 bytes, patch)
2008-08-27 19:31 UTC, Diego Elio Pettenò 		none Details | Review

Description Diego Elio Pettenò 2008-08-27 19:30:51 UTC 
Please describe the problem:
The target_LDFLAGS variable in automake is designed to pass flags to the linker, but swfdec-gnome 2.22.2 passes libraries through them, which is non-standard.

While libtool parameter reordering makes it fine even when passing -Wl,--as-needed through LDFLAGS, a compiler with specs modified to force --Wl,--as-needed on, or a linker with --as-needed forced on, will refuse to link correctly because of this.

The fix is very quick, replacing _LDFLAGS with _LIBADD.

HTH,
Diego

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Diego Elio Pettenò 2008-08-27 19:31:58 UTC 
Created attachment 117478 [details] [review]
Patch to fix.

I already submitted the patch to the Gentoo bug: http://bugs.gentoo.org/show_bug.cgi?id=232757
Comment 2 Benjamin Otte (Company) 2008-08-28 08:53:30 UTC 
committed.
Although I forgot to credit the patch to you in the commit message. :(