After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548850 - Mail Accounts "Add" and "Edit" buttons are missing ellipses
Mail Accounts "Add" and "Edit" buttons are missing ellipses
Status: RESOLVED WONTFIX
Product: evolution
Classification: Applications
Component: Mailer
2.22.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[accounts]
Depends on:
Blocks:
 
 
Reported: 2008-08-21 12:06 UTC by Matthew Paul Thomas (mpt)
Modified: 2009-05-24 21:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22



Description Matthew Paul Thomas (mpt) 2008-08-21 12:06:24 UTC
Evolution 2.22.3.1, Ubuntu 8.04

In the "Mail Accounts" pane of the Preferences window, the primary goal of someone clicking the "Add" button is to set up a mail account. But further action is required by the user before this task is completed. Therefore the button label should end in an ellipsis, i.e. "Add…".

The same applies to the "Edit" button: the primary goal of someone clicking that button is to edit an account, but just clicking the button by itself doesn't achieve this. Further input is required to actually do the editing, therefore the button should be labelled "Edit…".
Comment 1 André Klapper 2008-08-21 14:46:17 UTC
is this a HIG requirement? if so, feel free to add the keyword
Comment 2 Vadim Peretokin 2008-08-23 14:05:38 UTC
http://library.gnome.org/devel/hig-book/stable/controls-buttons.html.en

"Use an ellipsis (...) at the end of the label if the action requires further input from the user before it can be carried out. For example, Save As... or Find.... Do not add an ellipsis to commands like Properties, Preferences, or Settings, as these open windows that do not require further input."
Comment 3 Matthew Barnes 2009-05-24 21:05:11 UTC
I can kind of see the case for adding an ellipsis to "Add", but I disagree about "Edit".  Clicking "Edit" brings up the "Account Editor" window.  No further input is required to start editing the account.

However, I think I'd rather stick with using the stock GTK+ buttons (GTK_STOCK_ADD and GTK_STOCK_EDIT).  Since most use cases for adding something require further input, it might make more sense to fix this at the GTK+ level.

Therefore, closing as WONTFIX.
Comment 4 Vadim Peretokin 2009-05-24 21:13:56 UTC
Others don't, and this it will be wrong. So I really doubt someone at GTK+ level will fix this (I hope I'm wrong, but it's looking like a blame game deadlock atm).