After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548530 - wavenc allows audio depth of 25
wavenc allows audio depth of 25
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-19 21:01 UTC by David Schleef
Modified: 2008-10-04 21:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description David Schleef 2008-08-19 21:01:31 UTC
wavenc sinkpad caps:

      audio/x-raw-int
                   rate: [ 1, 2147483647 ]
               channels: [ 1, 2 ]
             endianness: 1234
                  width: 32
                  depth: [ 25, 32 ]
                 signed: true
      audio/x-raw-int
                   rate: [ 1, 2147483647 ]
               channels: [ 1, 2 ]
             endianness: 1234
                  width: 24
                  depth: [ 17, 24 ]
                 signed: true
      audio/x-raw-int
                   rate: [ 1, 2147483647 ]
               channels: [ 1, 2 ]
             endianness: 1234
                  width: 16
                  depth: [ 9, 16 ]
                 signed: true

This allows, for example, the creation of a 25-bit depth file.  I'm pretty sure this is not what any user wants, except perhaps in an enable-crazy-shit-that-will-only-cause-problems mode.  In the interest of sanity, I'm removing the ranges and replacing them with sane values.

Notably, the pipeline 'filesrc ! flacdec ! audioconvert ! wavenc ! filesink' will create a 25-bit-depth file, since flac outputs 24/32, and wavenc won't accept it, even though it's actually a common format.
Comment 1 David Schleef 2008-08-19 21:03:51 UTC
2008-08-19  David Schleef  <ds@schleef.org>

        * gst/wavenc/gstwavenc.c: Remove depth ranges and replace
        with sane values.  Fixes #548530.