After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548414 - Incomplete formats treated as completely invalid
Incomplete formats treated as completely invalid
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export other
git master
Other All
: Normal normal
: ---
Assigned To: Morten Welinder
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-08-19 11:04 UTC by Jody Goldberg
Modified: 2008-08-29 19:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A sample with the problem (1.60 KB, application/x-gnumeric)
2008-08-19 11:05 UTC, Jody Goldberg 		  Details
proposal (1.51 KB, patch)
2008-08-19 11:09 UTC, Jody Goldberg 		rejected Details | Review

Description Jody Goldberg 2008-08-19 11:04:30 UTC 
Apparently 1.6.x had a bug that generated incomplete formats in some situations
    ....;_(@_
NOTE : missing trailing ')' after the underscore.  The new fmt engine notes that this is invalid and drops the entire format.  We can be more lenient.
Comment 1 Jody Goldberg 2008-08-19 11:05:16 UTC 
Created attachment 116949 [details]
A sample with the problem

a sample from editgrid.
Comment 2 Jody Goldberg 2008-08-19 11:09:24 UTC 
Created attachment 116950 [details] [review]
proposal

The warning message is neither elegant nor informative but this is enough of a corner case that it doesn't see worthwhile going to extreme measures.
Comment 3 Jody Goldberg 2008-08-20 10:35:30 UTC 
Comment on attachment 116950 [details] [review]
proposal

As morten points out being lenient breaks the TEXT function in gnumeric.  gnumeric/samples/formats.xls shows the expected behavior on that end.

We need either a more pin point solution (e.g. handle this specific case in the importer) or an api change to chose between lenient and rigorous.
Comment 4 Morten Welinder 2008-08-29 19:01:49 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.