After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 545323 - Compositor should turn on and off from the command-line
Compositor should turn on and off from the command-line
Status: RESOLVED FIXED
Product: metacity
Classification: Other
Component: Iain's compositor
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Thomas Thurman
Metacity compositor maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-29 14:05 UTC by Thomas Thurman
Modified: 2008-08-31 22:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow command-line switches to enable and disable compositor (3.15 KB, patch)
2008-07-29 14:05 UTC, Thomas Thurman
none Details | Review

Description Thomas Thurman 2008-07-29 14:05:00 UTC
It seems, from reading blogs and forums, that many people like the idea of using Metacity's compositor but are scared of changing the deep magic of gconf.  In addition, there is nothing in the "--help" text to show that we have a compositor at all.  Therefore, I propose a new switch to override the current gconf setting for the compositor, which will display in "--help", and for symmetry another switch to turn it off again.

I am not sure whether --compositor and --no-compositor, or --composite and --no-composite, would be better names.

Patch coming up.
Comment 1 Thomas Thurman 2008-07-29 14:05:53 UTC
Created attachment 115493 [details] [review]
Allow command-line switches to enable and disable compositor

This also adds the short form "-d" for "--display", in conformity with various other X clients.
Comment 2 iain 2008-07-29 22:03:17 UTC
The patch says it doesn't feed back into gconf, but without that I don't see the point of the patch.

Surely anyone who can't use gconf-editor isn't going to be able to find out the black magic for changing the startup command for metacity to add --compositor. Hell, I'm not even sure how you'd go about to do that.

If instead the --compositor option turned it on in gconf forever then I sort of see the worth as you could just run

> metacity --replace --compositor 

once and have the compositor turned on for evermore, or at least til you ran --replace --no-compositor

In fact, you could have --compositor/--no-compositor imply --replace as well.
Comment 3 Thomas Thurman 2008-07-29 22:51:16 UTC
Thanks, good points.

As to the black magic, I think:

  * all non-hidden command-line options are displayed in --help, which is far more discoverable than anything exposed only through gconf

  * in my experience as a fly on the wall in blogs and forums, people complain about being asked to type "gconftool -t string -s /apps/metacity/whatever", whereas they generally don't have any particular worries about invoking Metacity itself directly.

I like the idea of feeding back into gconf, yes; it's counterintuitive that you then have to toggle gconf twice in order to make the change.

On the other hand, I'm thinking about people who aren't necessarily already running Metacity, who want to try it with the compositor perhaps once to see whether they like it.  But on the gripping hand, they can always give the argument again.

(One extra side-effect I haven't previously mentioned: this makes the compositor usable in non-gconf builds.  I don't know who's out there using Metacity with the compositor but without gconf, though.)
Comment 4 Thomas Thurman 2008-08-31 22:56:24 UTC
Addressed those concerns (except implying --replace; I think there may be a rule somewhere that we have to not replace unless --replace is used, and even if not people generally expect it) and checked in.

http://svn.gnome.org/viewvc/metacity?rev=3838&view=rev