After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544538 - Fix some build warnings
Fix some build warnings
Status: RESOLVED FIXED
Product: gnome-main-menu
Classification: Other
Component: libslab
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Federico Mena Quintero
GNOME main menu maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-24 13:05 UTC by Cosimo Cecchi
Modified: 2008-07-24 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (460 bytes, patch)
2008-07-24 13:05 UTC, Cosimo Cecchi 		none Details | Review

Description Cosimo Cecchi 2008-07-24 13:05:35 UTC 
Attached patch fixes a warning due to a missing "%s" in a call to g_critical (), which requires a printf-style formatted string.
Comment 1 Cosimo Cecchi 2008-07-24 13:05:57 UTC 
Created attachment 115164 [details] [review]
patch
Comment 2 Federico Mena Quintero 2008-07-24 16:34:16 UTC 
Make it

  g_critical ("Blah blah blah (%s)", desktop_file);

to avoid the temporary variable and please commit.  Thanks for catching this :)
Comment 3 Cosimo Cecchi 2008-07-24 17:17:08 UTC 
Thanks, I committed to trunk an updated version of the patch according to your comment.

2008-07-24  Cosimo Cecchi  <cosimoc@gnome.org>

	http://bugzilla.gnome.org/show_bug.cgi?id=544538

	* app-shell.c: (generate_launchers):
	Fix a build warning.