After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 544457 - -bad doesn't compile with MSVC
-bad doesn't compile with MSVC
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Normal blocker
: 0.10.8
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-23 22:33 UTC by Michael Smith
Modified: 2008-07-24 00:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Compile fixes for MSVC (3.71 KB, patch)
2008-07-23 22:34 UTC, Michael Smith 		accepted-commit_now Details | Review

Description Michael Smith 2008-07-23 22:33:18 UTC 
Patch to come: problematic plugins are modplug, festival, and sdp.
Comment 1 Michael Smith 2008-07-23 22:34:01 UTC 
Created attachment 115134 [details] [review]
Compile fixes for MSVC
Comment 2 Jan Schmidt 2008-07-24 00:30:13 UTC 
Looks fine
Comment 3 Michael Smith 2008-07-24 00:33:05 UTC 
2008-07-23  Michael Smith <msmith@songbirdnest.com>

    * gst/festival/gstfestival.c:
      Guard unistd.h with HAVE_UNISTD_H
    * gst/modplug/libmodplug/load_it.cpp:
    * gst/modplug/libmodplug/sndfile.cpp:
    * gst/modplug/libmodplug/sndfile.h:
    * gst/modplug/libmodplug/stdafx.h:
      Support for compiling with MSVC: use _MSC_VER for detecting MSVC instead
      of MSC_VER. Make CanPackSamples take the type it's passed. Change scope
      of a variable in load_it.cpp to MSVC's scoping rules.
    * gst/sdp/gstsdpdemux.c:
      Guard unistd.h with HAVE_UNISTD_H
      Fixes #544457.