After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543710 - Dead keys do not work anymore with DirectFB
Dead keys do not work anymore with DirectFB
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] Backend: directfb
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Michael Emmel
Depends on:
Blocks:
 
 
Reported: 2008-07-19 10:17 UTC by Josselin Mouette
Modified: 2009-02-18 17:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove DirectFB dead keys management (2.35 KB, patch)
2008-07-19 10:20 UTC, Josselin Mouette
committed Details | Review

Description Josselin Mouette 2008-07-19 10:17:25 UTC
Since version 0.9.26, DirectFB has its own layer to manage dead keys. Therefore, the code in GDK to handle it is useless and worse, make dead keys stop working.
Comment 1 Josselin Mouette 2008-07-19 10:20:21 UTC
Created attachment 114810 [details] [review]
Remove DirectFB dead keys management

Here is a proposed patch by Jérémy Bobbio in <http://bugs.debian.org/394871>. Note that I have not checked whether it works since I don’t use the DirectFB backend myself.
Comment 2 Sven Neumann 2009-02-16 19:42:10 UTC
We should depend on DirectFB 1.0.0, not some pre-1.0 version.

I would have comitted this change, but the whole tree does not compile at the moment (talking about gtk+ trunk). So we should try to get that fixed first. I am not going to commit changes into a tree that does not even compile.
Comment 3 Sven Neumann 2009-02-18 17:45:02 UTC
I have applied this change to trunk and to the gtk-2-14 branch:

2009-02-18  Sven Neumann  <sven@gimp.org>

	Bug 543710 – Dead keys do not work anymore with DirectFB

	* gdk/directfb/gdkkeys-directfb.c (gdk_directfb_translate_key):
	applied patch from Josselin Mouette that removes special handling
	of dead keys as that is done by DirectFB for a long time already.

2009-02-18  Sven Neumann  <sven@gimp.org>

	* configure.in: depend on DirectFB >= 1.0.0. There's no point in
	using an earlier development version.