After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 543300 - [qtdemux] [PATCH] wrong depth in RLE video caps and wrong qt par
[qtdemux] [PATCH] wrong depth in RLE video caps and wrong qt par
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal blocker
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-07-16 15:51 UTC by Mark Nauwelaerts
Modified: 2008-07-18 20:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Read RLE depth from proper location. (1.50 KB, patch)
2008-07-16 15:55 UTC, Mark Nauwelaerts 		none Details | Review
Revert pixel-aspect-ratio calculation. (2.19 KB, patch)
2008-07-16 16:39 UTC, Mark Nauwelaerts 		committed Details | Review

Description Mark Nauwelaerts 2008-07-16 15:51:08 UTC 
_parse_trak reads depth from stsd atom using an offset that by that time is already set for reading from tkhd atom, which evidently leads to wrong values.
Comment 1 Mark Nauwelaerts 2008-07-16 15:55:46 UTC 
Created attachment 114673 [details] [review]
Read RLE depth from proper location.

* Depth in stsd has already been read, take it from there instead of reading again.  Also, first read from tkhd, and then from stsd so as not to alter offset for optional later stsd processing.
Comment 2 Mark Nauwelaerts 2008-07-16 16:39:47 UTC 
Created attachment 114675 [details] [review]
Revert pixel-aspect-ratio calculation.

Upon further reflection, it is better to revert the commit that calculates pixel-aspect-ratio, which introduced the problem.  That calculation is otherwise correct according to ISO specs, but not to qt specs (sigh).  So better to avoid for now rather than having a FIXME about checking the file type.

Attached patch reverts.
Comment 3 Jan Schmidt 2008-07-18 18:02:38 UTC 
OK, let's revert
Comment 4 Mark Nauwelaerts 2008-07-18 20:04:03 UTC 
2008-07-18  Mark Nauwelaerts  <mark.nauwelaerts@collabora.co.uk>

	* gst/qtdemux/qtdemux.c: (gst_qtdemux_add_stream),
	(qtdemux_parse_trak):
	Revert ISO base media spec based pixel-aspect-ratio calculation.
	Fixes #543300.