GNOME Bugzilla – Bug 541782
Implement woohoo bar in Epiphany
Last modified: 2009-01-19 23:18:37 UTC
I believe the new address bar (the "Awesome Bar") in Firefox 3 represents a significant usability enhancement and would benefit Epiphany greatly. The Awesome Bar functions as the Address Bar, but makes suggestions from several sources including: * URLs in history * URLs in bookmarks * Page titles in history * Names of bookmarks This feature makes recalling previously visited or bookmarked pages much easier, as the user can associate content with minor context (usually page title, which represents the topic) rather than just the URL, and does not have to look through all bookmarks trying to remember which was what. Other information: The implementation in Firefox 3 also places a yellow star next to any bookmarked page (right-aligned on the location bar) both as part of the location bar and when suggesting results. This is not critical, but does help differentiate between "pages I've seen" and "pages I've bookmarked," adding one more piece of familiar information to the lookup.
(In reply to comment #0) > * URLs in history > * URLs in bookmarks > * Names of bookmarks As far as I know, Epiphany's address entry already searches in all of these AND topic names. Page titles would be a nice addition. The yellow star indicator is bug 350853. Is there something else I've forgotten?
The patch on bug 517960 would help a lot.
Created attachment 116537 [details] woohoo bar for ephy just an experiment i did this week, it has some backend issue though.
Retitling, attaching patches for woohoo bar here after a not so quick rebase. Oh and one more thing, it has a bug when the first time you open the completion, it's wrong sized. Screenshot follows.
Created attachment 116624 [details] [review] [PATCH] Implement the woohoo bar. This removes the extracell from the completion popup, it's now only one column wide with a woohoo look. It deprecates the bolding branch, but for now they must run parallel until we decide if we want this or not. Also this must be sporting the blank completion bug. --- lib/widgets/ephy-location-entry.c | 109 +++++++++++++++++++++++++------------ src/ephy-completion-model.c | 16 ++---- 2 files changed, 80 insertions(+), 45 deletions(-)
Created attachment 116625 [details] Sizing bug Appears when opening the completion for the first time.
The sizing problem is now fixed, I'll attach the updated patch. Note that this depends on GTK+ bug/patch #562701. Otherwise the popup just fails.
Created attachment 126388 [details] [review] [PATCH] Implement woohoo bar in epiphany lib/widgets/ephy-location-entry.c | 109 +++++++++++++++++++++++++------------ src/ephy-completion-model.c | 16 ++---- 2 files changed, 80 insertions(+), 45 deletions(-)
The GTK+ bug has been fixed, what do you say if I commit this ;) (and bump GTK+ dep)?
Committed to trunk, hopefully someone will be able to try it so we can decide on it being on 2.26.
Why can't you commit it to 2-26 and back it out in case of problems? That way, I can at least try it with the development packages in Cooker...
Now also in 2.26 :-)