After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 541632 - Nicks by color
Nicks by color
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Multi User Chat
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
Depends on:
Blocks: 649174
 
 
Reported: 2008-07-05 06:29 UTC by Xavier Claessens
Modified: 2011-10-08 20:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
theme-adium: implement %senderColor% (#541632) (3.03 KB, patch)
2011-05-02 11:37 UTC, Guillaume Desmottes
accepted-commit_now Details | Review

Description Xavier Claessens 2008-07-05 06:29:43 UTC
Hello, I'm trying empathy 0.22.1 for IRC.

 I'm used to color nicknames and I find difficult to follow a group
conversation without it. Something like assigning a random color for a nick
that says something and stick with this color for this nick.

I hope this help you improve this application.

[Note: I splitted bug #533638]
Comment 1 Juan Manuel Borges Caño 2008-07-20 21:30:01 UTC
I'm the original reporter.
Comment 2 Travis Reitter 2009-08-04 04:31:12 UTC
Now that MUC is somewhat usable, I think it's worth fixing this bug.

A few goals for the fix (in approximate order of importance):

1. maintain high contrast between the font background and foreground colors
2. reserve a color (and colors near it) for highlighting nicks on lines where they have quoted your name
3. maximize the color distinction between nicks
3.b. ideally, maximize color distinction between otherwise-similar nicks. The best criteria are probably same-length nicks and nicks with the same prefix.
Comment 3 Spreadsheet 2010-07-09 23:41:07 UTC
I think this would be a really useful feature. I like Pidgin's interface/look, and I think Empathy should do nick coloring the same as Pidgin.
Comment 4 Laurent Pointecouteau 2011-01-16 13:49:27 UTC
I agree with this. Maybe you can use the groupchat feature of Adium themes (bug #586386) and work on a default MUC message style ? I don't know if Adium themes can handle colored nicknames. Also, this feature is in use in Google Groups, where it looks very nice, in my opinion.
Comment 5 sotecware 2011-05-02 08:03:19 UTC
Note that the colours must be semi-random for maximum usability. It is important that the same nick *always* yields the same colour (even over multiple rejoins, restarts whatsoever), as long as the surroundings (foreground/background color) did not change. 

Spreadsheet pointed out pidgin, which does the best out of nick colouring for what I have seen so far.

best regards
Comment 6 Xavier Claessens 2011-05-02 08:08:08 UTC
For your informations, libempathy-gtk/empathy-theme-adium.c:

		} else if (theme_adium_match (&cur, "%senderColor%")) {
			/* FIXME: A color derived from the user's name. If a
			 * colon separated list of HTML colors is at
			 * Incoming/SenderColors.txt it will be used instead of
			 * the default colors.
			 */
Comment 7 Guillaume Desmottes 2011-05-02 11:37:59 UTC
Created attachment 187032 [details] [review]
theme-adium: implement %senderColor% (#541632)
Comment 8 Guillaume Desmottes 2011-05-02 11:41:05 UTC
I opened bug #649174 about the FIXME.
Comment 9 Xavier Claessens 2011-05-02 12:04:58 UTC
Review of attachment 187032 [details] [review]:

good
Comment 10 Guillaume Desmottes 2011-05-02 12:53:00 UTC
Merged to master.


commit 715bb21b4598091c2dac0ebf94b3d744056d01e6
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Mon May 2 13:36:42 2011 +0200

    theme-adium: implement %senderColor% (#541632)


This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 11 Laurent Pointecouteau 2011-10-01 23:03:22 UTC
I don't know if it's right to post this here, but I've noticed that the default "classic" style does not support yet this feature ; you've got to use an Adium style such as yMous to get different nick colors in the same MUC. I guess bug #645920 is here for fixing this.
Comment 12 Guillaume Desmottes 2011-10-08 20:12:27 UTC
Yeah plan is to switch to Adium themes so we don't care that much about the old ones.