GNOME Bugzilla – Bug 539640
Price Editor: Security disappears from price list
Last modified: 2018-06-29 22:05:59 UTC
Please describe the problem: If you have both the security editor and price editor open, and modify the security in the security editor, it can disappear from the price list. It will reappear if the price list is closed and reopened. Steps to reproduce: 1. Open price editor 2. Open security editor 3. Select a security in the security editor for which online quotes are enabled. 4. Disable online quotes for that security Actual results: The security disappears from the list in the price editor Expected results: The price editor would be unchanged Does this happen every time? Yes Other information:
I can reproduce this, and the patch for bug 376298 doesn't fix it.
Phil, There is some old workaround in gnc-tree-model-price.c where row deletion is delayed by use of an idle timer function. Some comments say that not doing it that way causes problems with the GtkTreeModelFilter. However, the workaround causes problems of its own, namely that the delay allows rows for the very same commodity to be added back in the meantime. Anyway, I tried disabling the delay and forcing immediate row deletion. It now works fine for me, but maybe it wouldn't in older GTK versions (I'm using 2.12.8). I'll attach a patch. Could you try it out and see if it works for you?
Created attachment 115476 [details] [review] For Phil to try (not for committing) Phil, this patch contains a few unrelated changes, but go ahead and try it. The only relevant change is really the last one, around the g_idle_add_full() call.
Actually Phil, I now see some deeper problems, so this patch isn't going to cut it. It fixes this problem but causes others. So don't worry about testing it.
Fix committed as r17441. Requesting backport for 2.2.
Applied to branches/2.2 as part of r17580 for inclusion in GnuCash 2.2.7. Thanks a lot!
GnuCash bug tracking has moved to a new Bugzilla host. This bug has been copied to https://bugs.gnucash.org/show_bug.cgi?id=539640. Please update any external references or bookmarks.