After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 539622 - use G_DEFINE_BOXED_TYPE
use G_DEFINE_BOXED_TYPE
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: pango-maint
pango-maint
Depends on: 449565
Blocks:
 
 
Reported: 2008-06-22 17:26 UTC by Christian Persch
Modified: 2010-11-04 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] Use G_DEFINE_BOXED_TYPE. (8.62 KB, patch)
2008-06-22 17:27 UTC, Christian Persch 		accepted-commit_after_freeze Details | Review
Use G_DEFINE_BOXED_TYPE. (9.97 KB, patch)
2010-08-17 22:20 UTC, Christian Persch 		none Details | Review

Description Christian Persch 2008-06-22 17:26:14 UTC 
as soon as it's available in gobject (bug 449565).
Comment 1 Christian Persch 2008-06-22 17:27:45 UTC 
Created attachment 113210 [details] [review]
[PATCH] Use G_DEFINE_BOXED_TYPE.

 pango/fonts.c            |   32 ++++++--------------------------
 pango/glyphstring.c      |   15 +++------------
 pango/pango-attributes.c |   15 +++------------
 pango/pango-color.c      |   15 +++------------
 pango/pango-glyph-item.c |   14 +++-----------
 pango/pango-item.c       |   14 +++-----------
 pango/pango-language.c   |   14 +++-----------
 pango/pango-layout.c     |   29 ++++++-----------------------
 pango/pango-matrix.c     |   15 +++------------
 pango/pango-tabs.c       |   14 +++-----------
 10 files changed, 36 insertions(+), 141 deletions(-)
Comment 2 Behdad Esfahbod 2008-06-23 00:01:54 UTC 
Good to go when glib patch lands.
Comment 3 André Klapper 2008-06-29 02:46:44 UTC 
That's what dependencies are for ;-)
Comment 4 Christian Persch 2010-08-17 22:20:07 UTC 
Created attachment 168143 [details] [review]
Use G_DEFINE_BOXED_TYPE.

Bug #539622.
Comment 5 Behdad Esfahbod 2010-08-18 22:50:14 UTC 
Thanks!  Please commit as soon as there is a glib version released with the macro.
Comment 6 Christian Persch 2010-11-04 21:25:04 UTC 
It's in 2.26. Ok to commit this now?
Comment 7 Behdad Esfahbod 2010-11-04 21:26:36 UTC 
Yep.  Rip them all out!
Comment 8 Christian Persch 2010-11-04 21:33:13 UTC 
Pushed to master.