GNOME Bugzilla – Bug 539188
When clicking row in file list, skip setting last_selected_name
Last modified: 2018-02-10 03:29:19 UTC
Copying from http://bugzilla.gnome.org/show_bug.cgi?id=419737#c64 ---- There are at least two different pieces of code that clears the file name entry upon changing directory. ... Second is update_chooser_entry line 6783. It is called if we go to a folder by any method. It clears the entry if the text in the entry is the same as the name of that last clicked file. (Well, almost, see new bug below. * ) ... The second one should let SAVE and CREATE_FOLDER modes skip the check, antoher patch for that. ... * New bug: The reason that not even in OPEN mode is entry cleared upon entering a subfolder is that the value of the last selected file gets fscked up when clicking the subfolder. The chooser doesn't know it's going to be a double-click but acts like it's a single click. So, it looks to the chooser like a custom file name and it's preserved. ... This is a minor issue. The attached patch makes the behaviour consistent. The entry is cleared depending on if the user writes changes the text in the entry by hand or not, and only if user did, the entry is preserved. I think this needs input from Federico, as I've previously discussed this change with him. Adding him to CC.
Created attachment 113077 [details] [review] Patch Patch. Only changes last_selected_name if we also set the entry. That way, users can enter subfolder without changing last_selected_name.
We're moving to gitlab! As part of this move, we are closing bugs that haven't seen activity in more than 5 years. If this issue is still imporant to you and still relevant with GTK+ 3.22 or master, please consider creating a gitlab issue for it.