GNOME Bugzilla – Bug 538455
Erroronous change in SVN (5748)
Last modified: 2008-06-15 21:17:33 UTC
Were the changes to rhythmdb/rhythmdb.h in 5748 accidentally committed? After attempting to build SVN (5749) with the patch in http://bugzilla.gnome.org/show_bug.cgi?id=345975 the build fails with: cc -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\"/usr/share/locale\" -DG_LOG_DOMAIN=\"RhythmDB\" -I.. -I../lib -I../widgets -I../metadata -I../lib -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/libgnomeui-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/gnome-keyring-1 -I/usr/include/libgnome-2.0 -I/usr/include/libbonoboui-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/libxml2 -I/usr/include/gail-1.0 -I/usr/include/libglade-2.0 -I/usr/include/gnome-vfs-module-2.0 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fno-strict-aliasing -g -O2 -g -Wall -O2 -c rhythmdb.c -fPIC -DPIC -o .libs/rhythmdb.o rhythmdb.c: In function 'set_props_from_metadata': rhythmdb.c:1684: warning: passing argument 4 of 'rhythmdb_entry_set_internal' makes integer from pointer without a cast rhythmdb.c: In function 'rhythmdb_entry_set_internal': rhythmdb.c:3140: error: case label does not reduce to an integer constant rhythmdb.c: In function 'rhythmdb_prop_type_get_type': rhythmdb.c:3929: warning: initialization makes integer from pointer without a cast rhythmdb.c: In function 'rhythmdb_entry_get_string': rhythmdb.c:4671: error: case label does not reduce to an integer constant make[3]: *** [rhythmdb.lo] Error 1 If I remove the changes to the rhythmdb.h file and rebuild it, it builds fine and works normally. Just checking if I missing something, does the patch need re-working, or was it an oversight?
Actually, upon cleaning ccache and doing a little more reading of the changes in 5748, it appears the patch does need a little re-working.
The patch needs to be reworked. It uses RHYTHMDB_PROP_COVER_ART_URI as a property, but my recent changes to rhythmdb/rhythmdb.h add a #define with that same name, which obviously won't work.