GNOME Bugzilla – Bug 537960
Gimp MIDI controller does not respond to correct channel from ALSA midi device
Last modified: 2008-10-30 20:13:49 UTC
Please describe the problem: When using an ALSA MIDI controller as an input device, Gimp does not respond to messages unless the Gimp MIDI channel is set to -1 or 0. If either is set, Gimp responds to messages on any MIDI channel. This is correct for channel -1 but not for channel 0. Steps to reproduce: 1. Start "gimp --verbose" in a terminal window and enable the MIDI controller input device 2. Connect Gimp MIDI to an Alsa midi controller (eg vkeybd) using aconnect 3. Send messages from vkeybd to Gimp by presing keys or changing controller values Actual results: When Gimp MIDI channel is set to -1 or 0 Gimp responds to messages, regardless of the channel used to transmit them. When Gimp MIDI channel is set to any other value it never responds, even when the matching channel is used to transmit the message Expected results: When Gimp MIDI channel is set to -1 or 0, all MIDI messages should be responded to regardless of the MIDI channel used. When Gimp MIDI channel is set to any other value (1 - 15) no messages are responded to, even if the channel numbers used match. Does this happen every time? When GIMP channel is set to -1, all MIDI messages should be responded to - this happens correctly. When channel is any other value (0 - 15), only messages on that channel should be responded to. Other information:
Created attachment 112605 [details] [review] Patch for modules/controller_midi.c, made against SVN 12/06/2008
Thank you, this patch is obviously correct. Will apply to both branches.
Fixed in both branches: 2008-06-12 Michael Natterer <mitch@gimp.org> * modules/controller_midi.c: applied patch from S. Fielding which passes the right MIDI channel from the ALSA event to midi_event(). Fixes bug #537960.