GNOME Bugzilla – Bug 537408
'Download complete' notification bubble should show "open file" button
Last modified: 2011-03-07 20:43:28 UTC
The summary says it all. Perhaps both a "open file" and "open folder" on the bubble would be even better.
Created attachment 117956 [details] [review] [PATCH] Add open and browse folder to download notification The notification bubble on completed downloads now has two action buttons to open the downloaded file and to browse to the containing folder, closes: #537408. --- embed/downloader-view.c | 39 +++++++++++++++++++++++++++++++++++++++ 1 files changed, 39 insertions(+), 0 deletions(-)
I'm missing a clear_actions() before adding the new ones, otherwise I can get to cases where the notification has 4 buttons or more.
Created attachment 119461 [details] [review] [PATCH] Add open and browse folder to download notification The notification bubble on completed downloads now has two action buttons to open the downloaded file and to browse to the containing folder, closes: #537408. --- embed/downloader-view.c | 43 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 43 insertions(+), 0 deletions(-)
Updated. This one is ready for review.
Well, before I review the patch there's a little matter to consider: what's the target of this patch? Obviously trunk, but ephy/webkit has not download support at all. And gnome-2-24 is feature frozen. Do you want to open a gnome-2-26-gecko branch for this?
+ g_app_info_launch_default_for_uri (uri, NULL, NULL); If we had a timestamp from the click, we would use a gdkapplaunchcontext here. Sucks that libnotify doesn't give the timestamp to us :( + /* Clear previous actions before adding new ones to avoid + * duplicate buttons in the popup + */ If say download 1 finished, has notify popup shown. Now download 2 finishes too. Do we show 2 popups? One popup? Should we show "Show file*s*" button, or "Show file 1" + "Show file 2" ? Apart from this question the patch looks good to me.
diegoe: ping?
I still have some bugs with this, but still interested... if you think it's a good idea I can finish it for this cycle.
(In reply to comment #8) > if you think it's a > good idea I can finish it for this cycle. Well, I'm not really sure. I seem to remember a discussion (usability list maybe?) where people thought buttons on notification bubbles were bad. As far as I'm concerned this isn't the most important issue -- I just wanted to make sure the patch wasn't forgotten about.
...ping? :)
The just committed bug #618443 (new downloads UI) makes this bug(s) obsolete.