After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537303 - Certain FF3 add-ons interfere with Orca's ability to provide access to content
Certain FF3 add-ons interfere with Orca's ability to provide access to content
Status: RESOLVED FIXED
Product: orca
Classification: Applications
Component: general
2.23.x
Other All
: Normal minor
: 2.24.4
Assigned To: Joanmarie Diggs (IRC: joanie)
Orca Maintainers
Depends on:
Blocks: 404403
 
 
Reported: 2008-06-08 20:27 UTC by Joanmarie Diggs (IRC: joanie)
Modified: 2009-01-31 00:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
revision 1 (853 bytes, patch)
2009-01-30 20:48 UTC, Joanmarie Diggs (IRC: joanie) 		committed Details | Review

Description Joanmarie Diggs (IRC: joanie) 2008-06-08 20:27:23 UTC 
I just discovered that the forecastfox add-on is somehow interfering with getDocumentFrame().  Exactly what it's doing I have yet to determine.  It might be causing the EMBEDS relation to not be present.  Regardless with the forecastfox add-on installed, we are not able to find the document frame. :-(

The main reason I am marking the severity as "minor" is this is a "problem where easy workaround is present."  The workaround is don't install forecastfox and disable it/uninstall it if you've already done so. :-) 

The other reason I'm marking it as "minor" is because I use and have tried lots of add-ons, and forecastfox is the only add-on I have found thus far which breaks things.  If we suddenly discover quite a few more exist, then we can up the severity.

That said, I would like to see if we can give getDocumentFrame() some additional smarts to handle this and similar situations.
Comment 1 Joanmarie Diggs (IRC: joanie) 2009-01-30 20:48:58 UTC 
Created attachment 127585 [details] [review]
revision 1

If getDocumentFrame fails to find the document frame, this patch works up the hierarchy from the locusOfFocus in an attempt to find one. Seems to solve the problem with the add-on in question, is pylinted, and is regression tested.

Will please review. Thanks!
Comment 2 Willie Walker 2009-01-30 23:05:03 UTC 
Looks good to me.  Thanks for finding this!
Comment 3 Joanmarie Diggs (IRC: joanie) 2009-01-31 00:45:45 UTC 
Thanks Will. Patch committed to both trunk and the gnome-2-24 branch. Closing as FIXED.