After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 537110 - sorting does not work always
sorting does not work always
Status: RESOLVED DUPLICATE of bug 517671
Product: banshee
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: 1.0
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-07 13:22 UTC by Thijs Vermeir
Modified: 2008-06-18 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
banshee wrong sort on track number (69.26 KB, image/png)
2008-06-07 13:22 UTC, Thijs Vermeir
  Details
Fixes the track sort bug. (1.41 KB, patch)
2008-06-17 12:24 UTC, Philip Roberts
needs-work Details | Review
Update to previous track sort fix (615 bytes, patch)
2008-06-18 00:58 UTC, Philip Roberts
none Details | Review

Description Thijs Vermeir 2008-06-07 13:22:05 UTC
I want to sort my library on Track number but this does not work for all albums.
Some albums really sort from 1->last_track but some don't...
Comment 1 Thijs Vermeir 2008-06-07 13:22:56 UTC
Created attachment 112316 [details]
banshee wrong sort on track number

Here is a screenshot of the behavior with my library.
Comment 2 Philip Roberts 2008-06-17 11:27:25 UTC
I have noticed this as well.

I believe it is the way banshee is sorting, If the tracks in an album do not all have the same artist then the sorting does not work correctly.
Comment 3 Philip Roberts 2008-06-17 12:24:10 UTC
Created attachment 112903 [details] [review]
Fixes the track sort bug.

Previously when sorting by track, sort would only work correctly if the tracks all had the same album and artist. 

This patch changes the behaviour so that the tracks must only have the same album title.

Improvements: If you have lots of compilation albums, these will now be sorted properly when sorted by track#.

Implications: If you have lots of albums with the same album name, by different artists, these will become mixed up when sorting by track#.

Given that sorting by track only seems to be useful to me when I am playing through a particular album from start to finish, I feel the new behaviour provided by this patch is preferable.
Comment 4 Bertrand Lorentz 2008-06-17 20:17:34 UTC
Thank you for your patch.

Some stuff from translators.xml slipped into your patch, please remove it.

I can't comment on the implications or merits of the change, as I don't have any compilation album.
Comment 5 Philip Roberts 2008-06-18 00:58:10 UTC
Created attachment 112953 [details] [review]
Update to previous track sort fix

Same as previous patch except the changes from translators.xml that appeared in the original patch have been removed.
Comment 6 Andrew Conkling 2008-06-18 02:22:58 UTC
Please look at bug 517671; I believe this is a duplicate? Can you test with current SVN to see if the problem is resolved?
Comment 7 Philip Roberts 2008-06-18 12:04:49 UTC
Andrew, I agree, the latest version does appear to have fixed this bug. Thanks.
Comment 8 Andrew Conkling 2008-06-18 12:45:11 UTC
Thanks for taking the time to report this bug and to test the fix.

*** This bug has been marked as a duplicate of 517671 ***