After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536857 - DATADIR definition conflicts with windows headers
DATADIR definition conflicts with windows headers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Windows
: Normal blocker
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-05 17:49 UTC by David Schleef
Modified: 2008-06-11 20:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
change DATADIR to GST_DATADIR (1.71 KB, patch)
2008-06-05 17:52 UTC, David Schleef
accepted-commit_now Details | Review

Description David Schleef 2008-06-05 17:49:28 UTC
i586-mingw32msvc-gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/home/ds/gst/win32/gstreamer-devel/include -D_GNU_SOURCE -DG_LOG_DOMAIN=g_log_domain_gstreamer -DGST_MAJORMINOR=\"0.10\" -DGST_DISABLE_DEPRECATED -I../libs -I.. -I.. -I/home/ds/gst/win32/gstreamer-devel/include/glib-2.0 -I/home/ds/gst/win32/gstreamer-devel/lib/glib-2.0/include -I/home/ds/gst/win32/gstreamer-devel/include/libxml2 -Wall -Werror -g -g -O2 -I/home/ds/gst/win32/gstreamer-devel/include -MT libgstreamer_0.10_la-gstpoll.lo -MD -MP -MF .deps/libgstreamer_0.10_la-gstpoll.Tpo -c gstpoll.c  -DDLL_EXPORT -DPIC -o .libs/libgstreamer_0.10_la-gstpoll.o
In file included from /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/objbase.h:73,
                 from /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/ole2.h:9,
                 from /usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/windows.h:114,
                 from gstpoll.c:71:
/usr/lib/gcc/i586-mingw32msvc/4.2.1-sjlj/../../../../i586-mingw32msvc/include/objidl.h:95: error: expected identifier or ‘(’ before string constant

This is due to the recent addition of "DATADIR" to config.h.  Windows headers use DATADIR as a typedef.
Comment 1 David Schleef 2008-06-05 17:52:16 UTC
Created attachment 112230 [details] [review]
change DATADIR to GST_DATADIR
Comment 2 Jan Schmidt 2008-06-06 06:21:35 UTC
Good lord. Thanks for catching that now! :)
Comment 3 Jan Schmidt 2008-06-11 09:11:57 UTC
Gonna commit this, or shall I?
Comment 4 Jan Schmidt 2008-06-11 20:07:23 UTC
OK, patch committed