GNOME Bugzilla – Bug 536656
Video support should be an extension
Last modified: 2020-03-17 08:21:37 UTC
how this is useful? for example, I utilize banshee as music player only and need no video playback, so if video library and playback would be a plugin I would simply disable it. sure there will be people who will want to disable music library and playback for example.
*** Bug 572791 has been marked as a duplicate of this bug. ***
Hi, I am using Banshee too. I think it is a great audio player and audio manager. But I don't use the video part (as I don't use the Podcast, Last.fm and webradio parts) as I use other programs to do it. I like to stick to the *NIX way (KISS, one program - one use). Can Video support be a plugin, and be disabled at will, like the Podcast, Last.fm, webradio parts, Mirage etc ?
*** Bug 608326 has been marked as a duplicate of this bug. ***
This is exactly why I registered. VLC is way to good. banshee is good in Audio, but I think the vast majority of users don't use it to watch video.
ditto. I would love the ability to 'disable' Video in the extensions/plugins list of Banshee. Love my Banshee - but never use the video feature.
Created attachment 177270 [details] [review] video as an etention here is a patch which move video as an extention
I haven't read the code but I wonder how this interacts with the importer. E.g. if the extension is disabled, what happens when the importer finds a video file? Other scenerios would be having imported a bunch, then deciding to disable the video source.
Review of attachment 177270 [details] [review]: This doesn't compile for me : Making all in Banshee.Services MCS ../../../bin/Banshee.Services.dll ./Banshee.Sources/SourceManager.cs(63,17): error CS0246: The type or namespace name `VideoLibrarySource' could not be found. Are you missing a using directive or an assembly reference? Just moving the class in an extension is not enough, as it is referenced in several places in Banshee.Services. Having code in the core depend on an extension is of course not wanted. Moreover, I think we have several places where we assume the ServiceManager.SourceManager.VideoLibrary property is not null. Those would have to be modified in order to handle the video extension being disabled. ::: src/Extensions/Banshee.Video/Banshee.Video/VideoLibrarySource.cs @@ +5,3 @@ +// Cool Extension Author <cool.extension@author.com> +// +// Copyright (C) 2010 Cool Extension Author I think this file is a copy of the original VideoLibrarySource.cs file, so the copyrights should be preserved @@ +42,3 @@ + // DatabaseSource - generic, DB-backed Track source; used by PlaylistSource + // PrimarySource - 'owns' tracks, used by DaapSource, DapSource + // LibrarySource - used by Music, Video, Podcasts, and Audiobooks Please remove the boilerplate comments
This patch was just a step because I do a big refactor to have a cover view for movies/tv-show. I just send it before the code has ever change too much. Now the code have change a lot. So I can not send a new patch with only that change. I have a view with cover and few metadata jobs... The code compile but is far from finished. So, I will have to stabilize the code first. PS: for copyright and comments it is generated by create-extension script. I have ever removed it in my version but it is far from the original...
Created attachment 178401 [details] [review] video as an etention To make a cleaner commit for video refactor. I restart and re add my code slowly into the branch. So I take the time to made a cleaner patch.
Created attachment 178402 [details] [review] video as an extension oops the last one do not compile so fix the build...
Review of attachment 178402 [details] [review]: Applies (though still has a hyena commit which shouldn't be there), compiles and works beautifully. It survives multiple load/unloads and works as expected.
I split this in two since it is two separate requests for extension work and Olivier is hard at work on the Video part of the equation. People simply wishing to see this code in action can read the following article: http://www.omgubuntu.co.uk/2011/01/banshee-video-tv-shows-windows-and-hackfest-oh-my/ Oliviers work in progress code seems to have moved to his github repo here: https://github.com/dufoli/banshee/commits/video
Please make this happen in 2.3.x :)
Bertrand, please review that. It is a good start for other bugs like add possibility to import podcast or multiple music library...
Banshee is not under active development anymore and had its last code changes more than three years ago. Its codebase has been archived. Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is being shut down) if anyone takes the responsibility for active development again. See https://gitlab.gnome.org/Infrastructure/Infrastructure/issues/264 for more info.