After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 536328 - Lastfm.Gui Account Dialog: Save&Close on Enter keypress.
Lastfm.Gui Account Dialog: Save&Close on Enter keypress.
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal enhancement
: 1.0
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-06-02 21:33 UTC by Peter de Kraker
Modified: 2008-06-24 22:07 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Lastfm.Gui SaveonEnter (2.07 KB, patch)
2008-06-02 21:36 UTC, Peter de Kraker 		accepted-commit_after_freeze Details | Review
Lastfm.Gui SaveonEnter - version 2 (2.07 KB, patch)
2008-06-08 22:00 UTC, Peter de Kraker 		committed Details | Review

Description Peter de Kraker 2008-06-02 21:33:48 UTC 
It was bothering me that the Last.FM account dialog, where you enter your username and password, didn't responded to pressing Enter. This patch adds that functionality.

Please review.
Comment 1 Peter de Kraker 2008-06-02 21:36:31 UTC 
Created attachment 112003 [details] [review]
Lastfm.Gui SaveonEnter

Updated version of the patch I earlier sent to the mailinglist.
Comment 2 Gabriel Burt 2008-06-02 21:39:55 UTC 
Looks pretty good Peter (glad you got rid of the Parent.Parent.Parent :) ).  Put spaces between method names and argument lists, eg my_method (foo) - see HACKING for the full scoop.
Comment 3 Peter de Kraker 2008-06-08 22:00:28 UTC 
Created attachment 112374 [details] [review]
Lastfm.Gui SaveonEnter - version 2

Added the mentioned spaces. Should comply to HACKING guidelines now.
Comment 4 Gabriel Burt 2008-06-24 22:07:31 UTC 
Committed, thanks Peter!