After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 535095 - EggToolPalette - support horizontal orientation, left-align labels and ellipsized text.
EggToolPalette - support horizontal orientation, left-align labels and ellips...
Status: RESOLVED FIXED
Product: libegg
Classification: Other
Component: other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Jan Arne Petersen
Libegg maintenance
Depends on: 535090
Blocks:
 
 
Reported: 2008-05-27 15:12 UTC by Jan Arne Petersen
Modified: 2009-02-16 11:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implementation (5.55 KB, patch)
2008-05-27 15:15 UTC, Jan Arne Petersen 		none Details | Review
Updated patch. Fix BOTH_HORIZ and TEXT style mode (6.20 KB, patch)
2008-05-27 19:47 UTC, Jan Arne Petersen 		none Details | Review
Updated patch. Fix BOTH_HORIZ style mode (9.09 KB, patch)
2008-05-28 11:08 UTC, Jan Arne Petersen 		committed Details | Review

Description Jan Arne Petersen 2008-05-27 15:12:39 UTC 
* Support horizontal orientation.
* Left-align labels (and center icons) in GTK_TOOLBAR_BOTH_HORIZ mode.
* Apply ellipses to text item labels
Comment 1 Jan Arne Petersen 2008-05-27 15:15:58 UTC 
Created attachment 111614 [details] [review]
Implementation

TODO:
* Left align text only in GTK_TOOLBAR_BOTH_HORIZ mode.
* Fix GTK_TOOLBAR_BOTH_HORIZ mode (center icon and text).
* No ellipses in GTK_TOOLBAR_BOTH mode?
Comment 2 Jan Arne Petersen 2008-05-27 15:16:39 UTC 
Depends on Bug 535090 – Allow GtkToolShell to control some more properties on GtkToolItems.
Comment 3 Jan Arne Petersen 2008-05-27 19:47:48 UTC 
Created attachment 111624 [details] [review]
Updated patch. Fix BOTH_HORIZ and TEXT style mode

TODO:

* Left aligned text in BOTH_HORIZ mode looks bad
* Ellipsize without a minimum tool item size is not usable (...)
Comment 4 Jan Arne Petersen 2008-05-28 11:08:24 UTC 
Created attachment 111652 [details] [review]
Updated patch. Fix BOTH_HORIZ style mode

See screenshot in bug 535090
Comment 5 Murray Cumming 2008-06-01 21:21:01 UTC 
Well done.

But the ChangeLog entry is rather bare:
http://svn.gnome.org/viewvc/libegg/trunk/ChangeLog?r1=879&r2=880

I like to have a description of what was done in each function. Probably only half of those functions were actually changed, of course.

I also prefer to see comments explaining the intention of code, before that code. For instance, before a large if() block. I know that the current code doesn't do that much, but I don't like that either.
Comment 6 Jan Arne Petersen 2008-06-02 07:44:40 UTC 
Ok.
Comment 7 Baptiste Mille-Mathias 2008-12-24 14:59:29 UTC 
Jan, any news on this bug?
Comment 8 Murray Cumming 2009-01-14 11:29:48 UTC 
Was this committed? Why is this bug still open?
Comment 9 Johannes Schmid 2009-02-16 11:24:58 UTC 
According to Jan-Arne this can be closed!