GNOME Bugzilla – Bug 531825
Possible to change preferences while in a game
Last modified: 2013-09-14 23:12:30 UTC
Please describe the problem: The properties dialog is non-modal, and doesn't get its state updated if already open and a game starts. This allows you to change the game speed mid game (resulting in a way to cheat the higher speed high scores) or as I just discovered crash the game by adding worms that weren't there initially. Steps to reproduce: Open the preferences dialog. Move it aside. Start a game. Click back on the options dialog and change the speed. Actual results: It allows you to follow the steps above. Game speed changes. Expected results: From looking at gnometris, I believe that the correct behavior would be to disable starting a new game while the properties is open. Does this happen every time? Yes. Other information: I may look at this in the future, but for now I won't be.
Created attachment 144635 [details] [review] Patch for not allowing the user to change preferences in gnibbles during gameplay Written at Hackfest '09 @ IIT-Madras, India.
*** Bug 603996 has been marked as a duplicate of this bug. ***
Review of attachment 144635 [details] [review]: Wow, shame this went unreviewed for so long. Nowadays the preferences dialog is modal and much smarter and most of this doesn't seem to be a problem anymore. But I wonder where your score goes if you change the speed during gameplay? Your score probably ought to be listed with the slowest speed there was. Or maybe you just shouldn't be able to change the speed.
Bryan has completely disabled the preferences dialog during gameplay, so this definitely isn't an issue anymore.