After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 531718 - gconf-editor crashes with SIGSEGV in gconf_client_add_dir
gconf-editor crashes with SIGSEGV in gconf_client_add_dir
Status: RESOLVED FIXED
Product: gconf-editor
Classification: Applications
Component: general
2.26.x
Other Linux
: Normal critical
: ---
Assigned To: Gconf Editor Maintainers
Gconf Editor Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-06 12:45 UTC by Sebastien Bacher
Modified: 2009-08-24 09:24 UTC
See Also:
GNOME target: ---
GNOME version: 2.25/2.26

Attachments
Don't overwrite list_model in popup-menu event (765 bytes, patch)
2009-08-04 06:54 UTC, Sergey Nizovtsev 		committed Details | Review

Description Sebastien Bacher 2008-05-06 12:45:01 UTC 
The bug has been opened on https://bugs.launchpad.net/ubuntu/+source/gconf-editor/+bug/219700

"gconf-editor 2.22.0-0ubuntu2
libgconf2-4 2.22.0-0ubuntu2

Unset all values and and move out of the folder (click on some other element in the tree).

Core was generated by `gconf-editor'.
Program terminated with signal 11, Segmentation fault.
[New process 3431]

+ Trace 197018

  • #0 gconf_client_add_dir
    at gconf-client.c line 551
  • #0 gconf_client_add_dir
    at gconf-client.c line 551
  • #1 gconf_list_model_set_root_path
    at gconf-list-model.c line 146
  • #2 gconf_editor_window_selection_changed
    at gconf-editor-window.c line 889
  • #3 IA__g_cclosure_marshal_VOID__VOID
    at /build/buildd/glib2.0-2.16.3/gobject/gmarshal.c line 77
  • #4 IA__g_closure_invoke
    at /build/buildd/glib2.0-2.16.3/gobject/gclosure.c line 490
  • #5 signal_emit_unlocked_R
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2440
  • #6 IA__g_signal_emit_valist
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2199
  • #7 IA__g_signal_emit
    at /build/buildd/glib2.0-2.16.3/gobject/gsignal.c line 2243
  • #8 ??
    from /usr/lib/libgtk-x11-2.0.so.0" 






Comment 1


Sebastien Bacher





          2009-04-11 12:27:34 UTC
        



https://bugs.launchpad.net/bugs/359532 is a similar crash on 2.26






Comment 2


Sergey Nizovtsev





          2009-08-04 06:52:51 UTC
        



It seems that this bug happens after popup menu has been activated via "popup-menu" signal (menu key).

Function gconf_editor_window_list_view_popup_menu calls gtk_tree_selection_get_selected and rewrites window->list_model with window->sorted_list_model (because list_view was associated with sorted_list_model at initialization).






Comment 3


Sergey Nizovtsev





          2009-08-04 06:54:59 UTC
        



Created attachment 139841 [details] [review]
Don't overwrite list_model in popup-menu event

Proposed fix






Comment 4


Cosimo Cecchi





          2009-08-24 09:24:59 UTC
        



Thanks for the patch, I pushed it to master.

commit 8fbaf480bc2a47dfb1d2698d82cb2c6547b3e811
Author: Cosimo Cecchi <cosimoc@gnome.org>
Date:   Mon Aug 24 11:20:09 2009 +0200

    Don't overwrite window->list_model in popup-menu callback
    
    This causes a crash, as the list view has another sort model on it, and
    later we will use it instead of the real model.
    Patch by Sergey Nizovtsev, fix bug #531718.