After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 531577 - get rid of twister.util.OrderedDict scangobj-merge.py
get rid of twister.util.OrderedDict scangobj-merge.py
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: common
git master
Other Linux
: Normal normal
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-05-05 15:58 UTC by Marc-Andre Lureau
Modified: 2008-05-06 08:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
get rid of twisted (2.41 KB, patch)
2008-05-05 15:58 UTC, Marc-Andre Lureau 		committed Details | Review

Description Marc-Andre Lureau 2008-05-05 15:58:06 UTC 
Twisted is not in jhbuild, this patch could help to get rid of the twisted dependency.

patch to replace "from twisted.python import util" with http://aspn.activestate.com/ASPN/Cookbook/Python/Recipe/107747 version (using dict directly), follow
Comment 1 Marc-Andre Lureau 2008-05-05 15:58:53 UTC 
Created attachment 110411 [details] [review]
get rid of twisted
Comment 2 Marc-Andre Lureau 2008-05-05 16:01:01 UTC 
oups, the patch should include the link, I think
Comment 3 Sebastian Dröge (slomo) 2008-05-05 18:29:39 UTC 
Looks good but what's the license of the ordered dictionary code?
Comment 4 Marc-Andre Lureau 2008-05-05 19:42:45 UTC 
from http://aspn.activestate.com/ASPN/Python/Cookbook/

Except where otherwise noted, recipes in the Python Cookbook are published under the Python license . 

http://www.python.org/psf/license/
Comment 5 Sebastian Dröge (slomo) 2008-05-06 08:03:36 UTC 
Thanks, committed your patch. Only change I did is mentioning from where the ordered dict class is based on and the license.

2008-05-06  Sebastian Dröge  <slomo@circular-chaos.org>

	Patch by: Marc-Andre Lureau <marcandre dot lureau at gmail dot com>

	* scangobj-merge.py:
	Don't depend on Twisted just for the OrderedDict but implement our
	own ordered dictionary class. Fixes bug #531577.