After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 531050 - Enable optional single-include
Enable optional single-include
Status: RESOLVED DUPLICATE of bug 538734
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal enhancement
: ---
Assigned To: pango-maint
pango-maint
Depends on:
Blocks:
 
 
Reported: 2008-05-02 12:06 UTC by Michael Natterer
Modified: 2008-06-17 18:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch implementing the above (22.06 KB, patch)
2008-05-02 12:07 UTC, Michael Natterer 		none Details | Review
Modified patch (22.72 KB, patch)
2008-05-05 16:32 UTC, Michael Natterer 		none Details | Review

Description Michael Natterer 2008-05-02 12:06:41 UTC 
Attached patch does the following:

- makes the build break if PANGO_DISABLE_SINGLE_INCLUDES is defined
  and anything except <pango/pango.h>, <pango/pangox.h> etc. is
  included.

- gets rid of unneded includes in headers all over the place
  (took great care to make sure this change is 100% backward compatible).

- adds new header <pango/pangofc.h> to enable above single-include
  policy.

- build everything with G_DISABLE_SINGLE_INCLUDES.

- build tests/ and examples/ with PANGO_DISABLE_SINGLE_INCLUDES.
Comment 1 Michael Natterer 2008-05-02 12:07:47 UTC 
Created attachment 110269 [details] [review]
Patch implementing the above
Comment 2 Michael Natterer 2008-05-05 16:32:49 UTC 
Created attachment 110415 [details] [review]
Modified patch

This patch changes what I just changed in glib:

Instead of checking for __PANGO_H__ etc. it now checks for
__PANGO_H_INSIDE__ which is the proper way to do it and
really catches all single includes.
Comment 3 Behdad Esfahbod 2008-06-17 18:23:26 UTC 

*** This bug has been marked as a duplicate of 538734 ***