Bug 529285 – [rganalysis] Unit test leaks a GstTagList

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 529285 - [rganalysis] Unit test leaks a GstTagList


Summary:	[rganalysis] Unit test leaks a GstTagList


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	gst-plugins-bad
Version:	git master
Hardware:	Other Linux

Importance:	Normal normal
Target Milestone:	0.10.7
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-04-21 21:46 UTC by Sebastian Dröge (slomo)
Modified:	2008-04-21 21:54 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
rganalysis-check.diff (607 bytes, patch) 2008-04-21 21:47 UTC, Sebastian Dröge (slomo)	committed	Details \| Review

Description Sebastian Dröge (slomo) 2008-04-21 21:46:06 UTC

Hi,
the rganalysis unit test leaks a GstTagList:

Running suite(s): rganalysis
==19107== 
==19107== 168 (20 direct, 148 indirect) bytes in 1 blocks are definitely lost in loss record 2,358 of 2,454
==19107==    at 0x4022AB8: malloc (vg_replace_malloc.c:207)
==19107==    by 0x42D171C: g_malloc (gmem.c:131)
==19107==    by 0x42E67FD: g_slice_alloc (gslice.c:824)
==19107==    by 0x42E7004: g_slice_alloc0 (gslice.c:833)
==19107==    by 0x4099C4A: gst_structure_id_empty_new_with_size (gststructure.c:116)
==19107==    by 0x4099CC2: gst_structure_copy (gststructure.c:289)
==19107==    by 0x407C444: gst_message_parse_tag (gstmessage.c:871)
==19107==    by 0x804A332: poll_tags (rganalysis.c:263)
==19107==    by 0x8050896: test_gap_buffers (rganalysis.c:773)
==19107==    by 0x402FF5F: srunner_run_all (in /home/slomo/projects/gstreamer/head/gstreamer/libs/gst/check/.libs/libgstcheck-0.10.so.0.16.0)
==19107==    by 0x8052238: main (rganalysis.c:1918)


Attached patch fixes this.

Comment 1 Sebastian Dröge (slomo) 2008-04-21 21:47:13 UTC

Created attachment 109656 [details] [review]
rganalysis-check.diff

Comment 2 Sebastian Dröge (slomo) 2008-04-21 21:54:04 UTC

2008-04-21  Sebastian Dröge  <slomo@circular-chaos.org>

        * tests/check/elements/rganalysis.c: (GST_START_TEST):
        Don't leak a tag list. Fixes bug #529285.