After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 529120 - Addition of -Wno-portability
Addition of -Wno-portability
Status: RESOLVED FIXED
Product: gnome-common
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Gnome Common Maintainer(s)
Gnome Common Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-04-20 20:35 UTC by Philip Van Hoof
Modified: 2009-03-19 20:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds -Wno-portability to automake (496 bytes, patch)
2008-04-20 20:37 UTC, Philip Van Hoof
none Details | Review

Description Philip Van Hoof 2008-04-20 20:35:21 UTC
Will add a patch later
Comment 1 Philip Van Hoof 2008-04-20 20:37:16 UTC
Created attachment 109599 [details] [review]
Adds -Wno-portability to automake

This patch adds -Wno-portability to automake. It 'assumes' the usage of gmake, though. Which is something the majority of GNOME modules assume anyway, nowadays.

Perhaps an additional check warning for 'make' not being 'gmake' in case GNU make is not being used, would be a wise extra check?
Comment 2 Christian Persch 2008-06-21 13:30:24 UTC
I'm all in favour, but maybe this should be discussed on d-d-l? I don't think a hard dep on gnu make is a problem, but others might disagree.
Comment 3 Rodney Dawes 2009-02-15 22:15:03 UTC
We already require GNU make anyway. I think this should go in. Both intltool and gnome-doc-utils already have a hard dep on GNU make.
Comment 4 Christian Persch 2009-03-19 20:18:16 UTC
There didn't seem to be much opposition, so I committed this to trunk.