GNOME Bugzilla – Bug 529031
auto_hide_size works only up to half of panel's size
Last modified: 2008-08-15 02:28:13 UTC
Please describe the problem: If auto_hide_size key value is more than half of panel's size value, then visible part of hidden panel has exactly half of panel's size pixels, but maximized windows doesn't touch this hidden panel. Steps to reproduce: 1. Open gconf-editor and head to panel's path 2. Set autohide on, panel's size at 48 and auto_hide_size at 36 (which is more than 1/2 * 48 = 24) 3. Maximize any window Actual results: You can see free space (12px height) betweeen maximized window and hidden panel. Expected results: I expect the visible part of hidden panel to have auto_hide_size pixels and no free space between panel and maximized windows. Does this happen every time? Yes, it does. Other information: This problem also exists at GNOME 2.22.1. I do own screenshot, but don't know yet how to attach. You can find it at http://img.wklej.org/images/13010gnome_panel_autohidesize.jpg
Created attachment 109577 [details] Image shows effects of setting to auto_hide_size at value larger than half of size value. This image shows exactly, what is the problem.
Created attachment 113228 [details] [review] Patch allows auto_hide_size be larger than half of panel's height Untested!
I fixed it another way. 2008-08-04 Vincent Untz <vuntz@gnome.org> * panel-toplevel.c: (panel_toplevel_update_struts): remove the special case for auto-hidden panels. We just update the struts as if they were normal panels, with their current position. This changes a bit the behavior (ie, full-screen windows resize when the panel gets unhidden and then hidden again), but after playing with it, I think the new behavior is actually quite nice. If we revert the change, then we'll have to fix bug #529031 by clamping auto_hide_size, like we do in panel_toplevel_update_auto_hide_position(). Fix bug #529031.
(In reply to comment #3) > I fixed it another way. > > 2008-08-04 Vincent Untz <vuntz@gnome.org> > > * panel-toplevel.c: (panel_toplevel_update_struts): remove the special > case for auto-hidden panels. We just update the struts as if they were > normal panels, with their current position. > This changes a bit the behavior (ie, full-screen windows resize when > the panel gets unhidden and then hidden again), but after playing with > it, I think the new behavior is actually quite nice. If we revert the > change, then we'll have to fix bug #529031 by clamping auto_hide_size, > like we do in panel_toplevel_update_auto_hide_position(). > Fix bug #529031. > That's not a fix, that's avoiding the problem.
(In reply to comment #4) > (In reply to comment #3) > > I fixed it another way. > > > > 2008-08-04 Vincent Untz <vuntz@gnome.org> > > > > * panel-toplevel.c: (panel_toplevel_update_struts): remove the special > > case for auto-hidden panels. We just update the struts as if they were > > normal panels, with their current position. > > This changes a bit the behavior (ie, full-screen windows resize when > > the panel gets unhidden and then hidden again), but after playing with > > it, I think the new behavior is actually quite nice. If we revert the > > change, then we'll have to fix bug #529031 by clamping auto_hide_size, > > like we do in panel_toplevel_update_auto_hide_position(). > > Fix bug #529031. > > > > That's not a fix, that's avoiding the problem. If you read the ChangeLog entry, you'll notice the "if we revert [...], then we'll have to fix bug #529031..." Anyway. I guess your comment meant that you dislike the new behavior. And we can indeed revert it (although I can't do it now because I'm travelling).
I strongly dislike the new behaviour too. We are getting Fedora bugs about it already...
In case it isn't clear: the 'new behaviour' I mean is that not only windows are jumping up and down to the tune of the hiding/unhiding panel, but desktop icons in nautilus are too.