After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528421 - Import follows symlinks blindly
Import follows symlinks blindly
Status: RESOLVED DUPLICATE of bug 621156
Product: f-spot
Classification: Other
Component: Import
0.4.x
Other All
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
Depends on:
Blocks:
 
 
Reported: 2008-04-16 15:18 UTC by pype_1999.geo
Modified: 2010-06-11 20:32 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description pype_1999.geo 2008-04-16 15:18:37 UTC
Please describe the problem:
If the directory imported contains a symbolic link, this link will be blindly followed by f-spot regardless of whether we already imported the pointed directory.

Moreover, if the link actually points backward, f-spot will loop while crawling the directory tree eventually halting after several (i counted 40) copies of the same picture have been imported.

Steps to reproduce:
1. create "fool" directory, put some picture there
2. create a symlink "bar" to ../fool in "fool" directory itself
3. import the "fool" directory


Actual results:
pictures are inserted as "fool/pic.png", "fool/bar/pic.png", "fool/bar/bar/pic.png", ... ,"fool/bar/bar/bar/.../bar/pic.png"

Expected results:
ideally, f-spot should detect that it is re-visiting a directory and skip it. If that can't be automated, an import option (default off) "follow symbolic links" should be available on non-windows platforms

Does this happen every time?
yes

Other information:
Comment 1 Maxxer 2010-06-11 20:32:39 UTC
fixed in latest master!

*** This bug has been marked as a duplicate of bug 621156 ***