After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 528418 - Missing configure check for sqlite
Missing configure check for sqlite
Status: RESOLVED FIXED
Product: desktop-data-model
Classification: Deprecated
Component: engine
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Owen Taylor
desktop-data-model-maint
Depends on:
Blocks:
 
 
Reported: 2008-04-16 15:05 UTC by Marco Pesenti Gritti
Modified: 2008-04-16 17:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix I was about to commit (2.19 KB, patch)
2008-04-16 15:52 UTC, Owen Taylor 		none Details | Review

Description Marco Pesenti Gritti 2008-04-16 15:05:27 UTC 
gcc -DHAVE_CONFIG_H -I. -I./config -DHIPPO_COMPILATION -DHIPPO_OS_LINUX -DVERSION_FILE=\"/home/marco/od/install/share/desktop-data-model/version\" -I./config -pthread -I/home/marco/od/install/include/glib-2.0 -I/home/marco/od/install/lib/glib-2.0/include -I/usr/include/loudmouth-1.0 -DDDM_I_KNOW_THIS_IS_UNSTABLE=1 -g -O2 -Wall -Wchar-subscripts -Wpointer-arith -Wcast-align -Wfloat-equal -Wsign-compare -fno-strict-aliasing -Wdeclaration-after-statement -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -MT libengine_la-hippo-sqlite-utils.lo -MD -MP -MF .deps/libengine_la-hippo-sqlite-utils.Tpo -c engine/hippo-sqlite-utils.c  -fPIC -DPIC -o .libs/libengine_la-hippo-sqlite-utils.o
In file included from engine/hippo-sqlite-utils.c:8:
engine/hippo-sqlite-utils.h:6:21: error: sqlite3.h: No such file or directory
Comment 1 Owen Taylor 2008-04-16 15:52:53 UTC 
Created attachment 109372 [details] [review]
Fix I was about to commit

Oops, didn't notice that you asigned it to yourself. I've attached the
patch I came up with. It does two things:

 - Requires explicit disabling of sqlite (it needs to stay optional
   in the code for the windows build, so I'd like to have a way
   to test disable on Linux, but accidental missing packages shouldn't
   cause non-functional FF3 integration.)
 - Don't build hippo-sqlite-utils if sqlite is disabled
Comment 2 Marco Pesenti Gritti 2008-04-16 17:31:11 UTC 
No problem, I had not started to work on it yet.

Tested it and it seem to work nicely, thanks!
Comment 3 Owen Taylor 2008-04-16 17:35:22 UTC 
r7268 | otaylor | 2008-04-16 13:34:09 -0400 (Wed, 16 Apr 2008) | 5 lines

- Make sqlite mandatory unless explicitly disabled
- Fix build with sqlite disabled