After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 524778 - libslab trivially depends on libeel
libslab trivially depends on libeel
Status: RESOLVED FIXED
Product: gnome-main-menu
Classification: Other
Component: libslab
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Federico Mena Quintero
GNOME main menu maintainers
Depends on:
Blocks: 349256
 
 
Reported: 2008-03-28 12:34 UTC by A. Walton
Modified: 2008-11-21 19:55 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
kill eel (3.86 KB, patch)
2008-03-28 12:35 UTC, A. Walton 		committed Details | Review

Description A. Walton 2008-03-28 12:34:59 UTC 
Right now libslab brings in Eel for some alert dialogs which work pretty well with just plain Gtk+. Trivial patch to remove the Eel dependency follows.
Comment 1 A. Walton 2008-03-28 12:35:33 UTC 
Created attachment 108170 [details] [review]
kill eel

And here it is.
Comment 2 Jens Granseuer 2008-03-28 19:21:48 UTC 
Moving to libslab, then...
Comment 3 Federico Mena Quintero 2008-07-23 20:10:39 UTC 
Thanks for taking care of this :)  Please go ahead and commit with a suitable ChangeLog.
Comment 4 André Klapper 2008-08-04 23:30:06 UTC 
awalton: ping
Comment 5 A. Walton 2008-08-11 16:18:22 UTC 
2008-08-11  A. Walton  <awalton@gnome.org>

	reviewed by: Federico Mena Quintero

	* directory-tile.c (delete_trigger):
	* document-tile.c (delete_trigger):
	Remove Eel dependency from libslab. Bug #524778.
Comment 6 Daniel Macks 2008-11-21 05:54:04 UTC 
Looks like the source-changes got propagated via the 2.24 branch, but as of 2.24.0.1, configure.in still has:

>PKG_CHECK_MODULES(LIBSLAB, $COMMON_MODULES gnome-desktop-2.0 librsvg-2.0 libgnome-menu pango eel-2.0)
Comment 7 Federico Mena Quintero 2008-11-21 18:19:40 UTC 
Ummm, awalton's commit removed that module from configure.in, too.  Where did you get the version you have?
Comment 8 Daniel Macks 2008-11-21 19:55:00 UTC 
Ooh, libslab *stand-alone*. I'm looking at gnome-control-center-2.24.0.1. Which apparently ships its own onboard eel out-of-sync with libslab itself? I finally remember to search before filing a dup bug, find the exact problem, but for the wrong pkg...
Comment 9 Daniel Macks 2008-11-21 19:55:36 UTC 
(er, s/eel/libslab/ in comment #8)